You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2016/08/23 22:36:23 UTC
[GitHub] brooklyn-server pull request #305: BROOKLYN-338: BrooklynApi fixes for karaf
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/305
BROOKLYN-338: BrooklynApi fixes for karaf
These aren\u2019t enough to fix BROOKLYN-338, but it\u2019s a start:
* Ensures rest-client imports the resteasy marshallers package,
which it calls with reflection (via the resteasy ProxyBuilder).
* Passes the ProxyBuilder a classloader that has access to the
rest-api classes and to rest-client\u2019s classloader (which thus
can access the marshallers).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server BROOKLYN-338
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/305.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #305
----
commit f270f09e345252e065fdc03ce70b02a2beb4de87
Author: Aled Sage <al...@gmail.com>
Date: 2016-08-23T22:35:47Z
BROOKLYN-338: BrooklynApi fixes for karaf
These aren\u2019t enough to fix BROOKLYN-338, but it\u2019s a start:
* Ensures rest-client imports the resteasy marshallers package,
which it calls with reflection (via the resteasy ProxyBuilder).
* Passes the ProxyBuilder a classloader that has access to the
rest-api classes and to rest-client\u2019s classloader (which thus
can access the marshallers).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #305: BROOKLYN-338: BrooklynApi fixes for karaf
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/305
Jenkins failure was for `OsTest.testDeleteRecursivelyEmptyDir`, failing for the 1000 attempts like:
2016-08-23 22:38:29,719 WARN Attempt to create temp dir failed /tmp/OsTest-IicA. Either an IO error (disk full, no rights) or someone else created the folder after the !exists() check.
Presumably "just" the build machine had run out of disk space! So assuming it wasn't our tests that filled up the disk, then this error is not related to our code.
---
I've incorporated Svet's comment and squashed the commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #305: BROOKLYN-338: BrooklynApi fixes for karaf
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #305: BROOKLYN-338: BrooklynApi fixes for karaf
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/305
Tests are passing locally, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #305: BROOKLYN-338: BrooklynApi fixes for karaf
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/305#discussion_r76028040
--- Diff: rest/rest-client/pom.xml ---
@@ -144,5 +144,21 @@
<scope>test</scope>
</dependency>
</dependencies>
-
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <version>2.5.3</version>
--- End diff --
Remove version, already defined (as `2.5.4`) in `brooklyn-parent`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #305: BROOKLYN-338: BrooklynApi fixes for karaf
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-server/pull/305
LGTM, build failure is unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---