You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2016/04/07 22:30:26 UTC

[jira] [Updated] (SPARK-14465) Checkstyle should check all Java files.

     [ https://issues.apache.org/jira/browse/SPARK-14465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun updated SPARK-14465:
----------------------------------
    Description: 
Currently, `checkstyle` is configured to check the files under `src/main/java`. However, Spark has Java files in `src/main/scala`, too.

This issue fixes the following configuration and checkstyle violations on those files.
{code:title=pom.xml|borderStyle=solid}
-<sourceDirectory>${basedir}/src/main/java</sourceDirectory>
+<sourceDirectories>${basedir}/src/main/java,${basedir}/src/main/scala</sourceDirectories>
{code}


  was:
Currently, `checkstyle` is configured to check the files under `src/main/java`. However, Spark has Java files in `src/main/scala`, too.

This issue fixes the following configuration and checkstyle violations on those files.
{code:title=pom.xml|borderStyle=solid}}
-<sourceDirectory>${basedir}/src/main/java</sourceDirectory>
+<sourceDirectories>${basedir}/src/main/java,${basedir}/src/main/scala</sourceDirectories>
{code}



> Checkstyle should check all Java files.
> ---------------------------------------
>
>                 Key: SPARK-14465
>                 URL: https://issues.apache.org/jira/browse/SPARK-14465
>             Project: Spark
>          Issue Type: Bug
>          Components: Build
>            Reporter: Dongjoon Hyun
>            Priority: Minor
>
> Currently, `checkstyle` is configured to check the files under `src/main/java`. However, Spark has Java files in `src/main/scala`, too.
> This issue fixes the following configuration and checkstyle violations on those files.
> {code:title=pom.xml|borderStyle=solid}
> -<sourceDirectory>${basedir}/src/main/java</sourceDirectory>
> +<sourceDirectories>${basedir}/src/main/java,${basedir}/src/main/scala</sourceDirectories>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org