You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by sb2nov <gi...@git.apache.org> on 2017/01/16 23:57:05 UTC
[GitHub] beam pull request #1782: [BEAM-886] Implement annotation based NewDoFn
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/1782
[BEAM-886] Implement annotation based NewDoFn
- Implement the new annotation based DoFn in python see https://s.apache.org/a-new-dofn
- Migrate all the cases of DoFn to NewDoFn
- CallableWrapperDoFn now extends NewDoFn
- Typechecking is also handled using the NewDoFn
Future Work:
- Remove OldDoFn completely from the code
- Deprecate the use of Context and pass state directly to the process method
Open question:
- This changes the semantics of process being called with a single window instead of a windowSet which is why `apache_beam.transforms.sideinputs_test:SideInputsTest.test_sliding_windows` is failing.
R: @robertwb PTAL
---
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/incubator-beam BEAM-prototype-new-dofn
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1782.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1782
----
commit 6d4e2539f9f2f42bff45b1861f9d3f67d915bd30
Author: Sourabh Bajaj <so...@google.com>
Date: 2017-01-16T23:50:17Z
Implement annotation based NewDoFn
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #1782: [BEAM-886] Implement annotation based NewDoFn in Py...
Posted by sb2nov <gi...@git.apache.org>.
Github user sb2nov closed the pull request at:
https://github.com/apache/beam/pull/1782
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---