You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by sr...@apache.org on 2018/01/18 16:06:14 UTC

[2/3] flink git commit: [hotfix][tests] separate tests inside SlotCountExceedingParallelismTest

[hotfix][tests] separate tests inside SlotCountExceedingParallelismTest

This way, in case of failures, we may have better pointers on what test code is
currently executed.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/75833655
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/75833655
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/75833655

Branch: refs/heads/master
Commit: 758336553248d2414a88b071ebd5748c1c32d282
Parents: 665347c
Author: Nico Kruber <ni...@data-artisans.com>
Authored: Tue Aug 29 11:49:47 2017 +0200
Committer: Stefan Richter <s....@data-artisans.com>
Committed: Thu Jan 18 17:05:00 2018 +0100

----------------------------------------------------------------------
 .../SlotCountExceedingParallelismTest.java        | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/75833655/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/SlotCountExceedingParallelismTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/SlotCountExceedingParallelismTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/SlotCountExceedingParallelismTest.java
index 4ce83cc..a881233 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/SlotCountExceedingParallelismTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/SlotCountExceedingParallelismTest.java
@@ -45,6 +45,8 @@ public class SlotCountExceedingParallelismTest extends TestLogger {
 	private static final int NUMBER_OF_SLOTS_PER_TM = 2;
 	private static final int PARALLELISM = NUMBER_OF_TMS * NUMBER_OF_SLOTS_PER_TM;
 
+	public static final String JOB_NAME = "SlotCountExceedingParallelismTest (no slot sharing, blocking results)";
+
 	private static TestingCluster flink;
 
 	@BeforeClass
@@ -63,19 +65,23 @@ public class SlotCountExceedingParallelismTest extends TestLogger {
 	}
 
 	@Test
-	public void testNoSlotSharingAndBlockingResult() throws Exception {
-		final String jobName = "SlotCountExceedingParallelismTest (no slot sharing, blocking results)";
-
+	public void testNoSlotSharingAndBlockingResultSender() throws Exception {
 		// Sender with higher parallelism than available slots
-		JobGraph jobGraph = createTestJobGraph(jobName, PARALLELISM * 2, PARALLELISM);
+		JobGraph jobGraph = createTestJobGraph(JOB_NAME, PARALLELISM * 2, PARALLELISM);
 		submitJobGraphAndWait(jobGraph);
+	}
 
+	@Test
+	public void testNoSlotSharingAndBlockingResultReceiver() throws Exception {
 		// Receiver with higher parallelism than available slots
-		jobGraph = createTestJobGraph(jobName, PARALLELISM, PARALLELISM * 2);
+		JobGraph jobGraph = createTestJobGraph(JOB_NAME, PARALLELISM, PARALLELISM * 2);
 		submitJobGraphAndWait(jobGraph);
+	}
 
+	@Test
+	public void testNoSlotSharingAndBlockingResultBoth() throws Exception {
 		// Both sender and receiver with higher parallelism than available slots
-		jobGraph = createTestJobGraph(jobName, PARALLELISM * 2, PARALLELISM * 2);
+		JobGraph jobGraph = createTestJobGraph(JOB_NAME, PARALLELISM * 2, PARALLELISM * 2);
 		submitJobGraphAndWait(jobGraph);
 	}