[jira] [Commented] (GEODE-4145) Clean up error code handling in protobuf

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300774#comment-16300774 ] 

ASF GitHub Bot commented on GEODE-4145:
---------------------------------------

WireBaron opened a new pull request #1202: GEODE-4145: Clean up protobuf error codes.
URL: https://github.com/apache/geode/pull/1202
 
 
   Remove all unused error codes.
   Condense all operation server exceptions into one ServerError type
   Condense all protocol errors into one InvalidRequest type
   Renumber error codes to be more compactable in protobuf msgs
   
   
   @PivotalSarge @upthewaterspout @bschuchardt @galen-pivotal 
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Clean up error code handling in protobuf
> ----------------------------------------
>
>                 Key: GEODE-4145
>                 URL: https://issues.apache.org/jira/browse/GEODE-4145
>             Project: Geode
>          Issue Type: Task
>          Components: client/server
>            Reporter: Brian Rowe
>
> We currently have some unused error codes in ProtocolErrorCode:
> UNSUPPORTED_VERSION(1101),
> HANDSHAKE_REQUIRED(1104),
> LOW_MEMORY(1300), <-- maybe this one should be used?
> BAD_QUERY(2001),
> QUERY_PARAMETER_MISMATCH(2200),
> QUERY_BIND_FAILURE(2201),
> QUERY_NOT_PERMITTED(2202),
> QUERY_TIMEOUT(2203);
> We also have a strange and incomplete list of exceptions that we catch and in some cases incorrectly map to some of these error codes. For example GetAllRequestOperationHandler catches "CacheLoaderException" and reports that as DATA_UNREACHABLE, which is not what a CacheLoaderException means.
> We need to review the exceptions we catch and the error codes we want to support and clean them up consistently across all operations.
> We may want to change the default behavior for unknown exceptions - it seems like maybe we just close the connection to the client without reporting the error message to the client for exceptions we haven't handled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)