You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/11/01 05:50:10 UTC
[GitHub] [fineract] IOhacker opened a new pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
IOhacker opened a new pull request #1944:
URL: https://github.com/apache/fineract/pull/1944
## Description
Adding UI to K8s deployment (FINERACT-1419)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [X] Create/update unit or integration tests for verifying the changes made.
- [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ohadzer commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
ohadzer commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-970299867
anything new with this PR? I'm really waiting for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ohadzer commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
ohadzer commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-997855123
Anything new? I'm still waiting for it
I tried to test the branch and it didn't work
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-958518077
Concept looks OK, but I think there's a problem in the docker-compose.yml:
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.community-app.depends_on contains an invalid type, it should be an array
services.fineract-server.depends_on contains an invalid type, it should be an array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-996290123
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-970335307
Hello,
I have been with some work load, it will be fixed tonight.
El mar, 16 nov 2021 a las 7:58, ohadzer ***@***.***>)
escribió:
> anything new with this PR? I'm really waiting for it
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1944#issuecomment-970299867>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAVMSROO2XDFOIXDETTUMJPP3ANCNFSM5HDIQJGQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-958583381
Hello,
It is because the version of Docker Compose in Travis-Ci, I will send a fix
in the travis yml
El mar, 2 nov 2021 a las 18:26, Petri Tuomola ***@***.***>)
escribió:
> Concept looks OK, but I think there's a problem in the docker-compose.yml:
>
> ERROR: The Compose file './docker-compose.yml' is invalid because:
> services.community-app.depends_on contains an invalid type, it should be
> an array
> services.fineract-server.depends_on contains an invalid type, it should be
> an array
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1944#issuecomment-958518077>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZASQYP4ALRP2ULXRSWDUKB6UTANCNFSM5HDIQJGQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-958518077
Concept looks OK, but I think there's a problem in the docker-compose.yml:
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.community-app.depends_on contains an invalid type, it should be an array
services.fineract-server.depends_on contains an invalid type, it should be an array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-958583381
Hello,
It is because the version of Docker Compose in Travis-Ci, I will send a fix
in the travis yml
El mar, 2 nov 2021 a las 18:26, Petri Tuomola ***@***.***>)
escribió:
> Concept looks OK, but I think there's a problem in the docker-compose.yml:
>
> ERROR: The Compose file './docker-compose.yml' is invalid because:
> services.community-app.depends_on contains an invalid type, it should be
> an array
> services.fineract-server.depends_on contains an invalid type, it should be
> an array
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1944#issuecomment-958518077>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZASQYP4ALRP2ULXRSWDUKB6UTANCNFSM5HDIQJGQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ohadzer edited a comment on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
ohadzer edited a comment on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-970299867
Anything new with this PR? I'm really waiting for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-958518077
Concept looks OK, but I think there's a problem in the docker-compose.yml:
ERROR: The Compose file './docker-compose.yml' is invalid because:
services.community-app.depends_on contains an invalid type, it should be an array
services.fineract-server.depends_on contains an invalid type, it should be an array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1944:
URL: https://github.com/apache/fineract/pull/1944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-1000340675
@ohadzer I've rebased this as a separate PR and merged it - so the latest develop branch should now have this included...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] IOhacker commented on pull request #1944: Adding UI to K8s deployment (FINERACT-1419)
Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1944:
URL: https://github.com/apache/fineract/pull/1944#issuecomment-958583381
Hello,
It is because the version of Docker Compose in Travis-Ci, I will send a fix
in the travis yml
El mar, 2 nov 2021 a las 18:26, Petri Tuomola ***@***.***>)
escribió:
> Concept looks OK, but I think there's a problem in the docker-compose.yml:
>
> ERROR: The Compose file './docker-compose.yml' is invalid because:
> services.community-app.depends_on contains an invalid type, it should be
> an array
> services.fineract-server.depends_on contains an invalid type, it should be
> an array
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1944#issuecomment-958518077>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZASQYP4ALRP2ULXRSWDUKB6UTANCNFSM5HDIQJGQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org