You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Lars George <la...@gmail.com> on 2011/05/30 16:02:21 UTC

Memstore Limit?

Hi,

See below from MemStoreFlusher.java (trunk):

  static long getMemStoreLimit(final long max, final float limit,
      final float defaultLimit) {
    if (limit >= 0.9f || limit < 0.1f) {
      LOG.warn("Setting global memstore limit to default of " + defaultLimit +
        " because supplied value outside allowed range of 0.1 -> 0.9");
    }
    return (long)(max * limit);
  }

The log message says it is using defaultLimit, but the code is not.
Should we fix either?

Lars

Re: Memstore Limit?

Posted by Stack <st...@duboce.net>.
Committed Ted's patch to branch and trunk.
St.Ack

On Mon, May 30, 2011 at 7:11 AM, Ted Yu <yu...@gmail.com> wrote:
> See https://issues.apache.org/jira/browse/HBASE-3934
>
> Thanks Lars
>
> On Mon, May 30, 2011 at 7:02 AM, Lars George <la...@gmail.com> wrote:
>
>> Hi,
>>
>> See below from MemStoreFlusher.java (trunk):
>>
>>  static long getMemStoreLimit(final long max, final float limit,
>>      final float defaultLimit) {
>>    if (limit >= 0.9f || limit < 0.1f) {
>>      LOG.warn("Setting global memstore limit to default of " + defaultLimit
>> +
>>        " because supplied value outside allowed range of 0.1 -> 0.9");
>>    }
>>    return (long)(max * limit);
>>  }
>>
>> The log message says it is using defaultLimit, but the code is not.
>> Should we fix either?
>>
>> Lars
>>
>

Re: Memstore Limit?

Posted by Ted Yu <yu...@gmail.com>.
See https://issues.apache.org/jira/browse/HBASE-3934

Thanks Lars

On Mon, May 30, 2011 at 7:02 AM, Lars George <la...@gmail.com> wrote:

> Hi,
>
> See below from MemStoreFlusher.java (trunk):
>
>  static long getMemStoreLimit(final long max, final float limit,
>      final float defaultLimit) {
>    if (limit >= 0.9f || limit < 0.1f) {
>      LOG.warn("Setting global memstore limit to default of " + defaultLimit
> +
>        " because supplied value outside allowed range of 0.1 -> 0.9");
>    }
>    return (long)(max * limit);
>  }
>
> The log message says it is using defaultLimit, but the code is not.
> Should we fix either?
>
> Lars
>