You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "damooo (via GitHub)" <gi...@apache.org> on 2023/03/28 17:22:52 UTC
[GitHub] [incubator-opendal] damooo opened a new issue, #1791: KV backend's writer will not create object with empty content.
damooo opened a new issue, #1791:
URL: https://github.com/apache/incubator-opendal/issues/1791
https://github.com/apache/incubator-opendal/blob/2d174fc26cc2d16d17399775035261cd0d68352b/core/src/raw/adapters/kv/backend.rs#L299
As in above snippet, if buffer is empty, it skips insertion of object in store. But returns success. It must create entry with empty content.
May be proper way to differentiate uninitialized buffer from empty buffer is to use `Option`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on issue #1791: KV backend's writer will not create object with empty content.
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1791:
URL: https://github.com/apache/incubator-opendal/issues/1791#issuecomment-1487327983
Nice idea. We are working a new design for kv adapter. Let's fix this after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] damooo commented on issue #1791: KV backend's writer will not create object with empty content.
Posted by "damooo (via GitHub)" <gi...@apache.org>.
damooo commented on issue #1791:
URL: https://github.com/apache/incubator-opendal/issues/1791#issuecomment-1487331641
Great that is. But this bug is failing my tests. I will comment them out till then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo closed issue #1791: KV backend's writer will not create object with empty content.
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #1791: KV backend's writer will not create object with empty content.
URL: https://github.com/apache/incubator-opendal/issues/1791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org