[GitHub] [apisix] starsz commented on a diff in pull request #8050: feat(kafka-logger): support sasl config in brokers

[GitBox <gi...@apache.org>]

starsz commented on code in PR #8050:
URL: https://github.com/apache/apisix/pull/8050#discussion_r990947531


##########
apisix/plugins/kafka-logger.lua:
##########
@@ -68,6 +68,19 @@ local schema = {
                         maximum = 65535,
                         description = "the port of kafka broker",
                     },
+                    sasl_config = {
+                        type = "object",
+                        description = "sasl config",
+                        properties = {
+                            mechanism = {
+                                type = "string",
+                                default = "PLAIN"

Review Comment:
   Good suggestion. Let me add the enum and add a test case to cover it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org