Re: [PR] [SPARK-56977][SQL] RewriteNearestByJoin should respect joinType in the synthetic join [spark]

["andylam-db (via GitHub)" <gi...@apache.org>]

andylam-db commented on code in PR #56023:
URL: https://github.com/apache/spark/pull/56023#discussion_r3277901995


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RewriteNearestByJoinSuite.scala:
##########
@@ -21,7 +21,7 @@ import org.apache.spark.sql.catalyst.dsl.expressions._
 import org.apache.spark.sql.catalyst.dsl.plans._

Review Comment:
   Since this wasn't caught in the previous PR, could we add tests to make sure the logic is correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org