You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2014/02/05 18:13:01 UTC
svn commit: r1564836 - in
/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2:
TestBasicDataSource.java TesterDriver.java
Author: sebb
Date: Wed Feb 5 17:13:01 2014
New Revision: 1564836
URL: http://svn.apache.org/r1564836
Log:
constant does not need to be exposed to sub-classes
Modified:
commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java
commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterDriver.java
Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java?rev=1564836&r1=1564835&r2=1564836&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TestBasicDataSource.java Wed Feb 5 17:13:01 2014
@@ -573,7 +573,7 @@ public class TestBasicDataSource extends
* TesterDriver that keeps a static count of connection requests.
*/
class TesterConnRequestCountDriver extends TesterDriver {
- protected static final String CONNECT_STRING = "jdbc:apache:commons:testerConnRequestCountDriver";
+ private static final String CONNECT_STRING = "jdbc:apache:commons:testerConnRequestCountDriver";
private static int connectionRequestCount = 0;
@Override
Modified: commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterDriver.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterDriver.java?rev=1564836&r1=1564835&r2=1564836&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterDriver.java (original)
+++ commons/proper/dbcp/trunk/src/test/java/org/apache/commons/dbcp2/TesterDriver.java Wed Feb 5 17:13:01 2014
@@ -132,7 +132,7 @@ public class TesterDriver implements Dri
throw new SQLFeatureNotSupportedException();
}
- protected static final String CONNECT_STRING = "jdbc:apache:commons:testdriver";
+ private static final String CONNECT_STRING = "jdbc:apache:commons:testdriver";
// version numbers
private static final int MAJOR_VERSION = 1;