[GitHub] [flink] pnowojski commented on a change in pull request #13761: [FLINK-19741] Allow AbstractStreamOperator to skip restoring timers if subclasses are using raw keyed state

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #13761:
URL: https://github.com/apache/flink/pull/13761#discussion_r511802915



##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamTaskStateInitializer.java
##########
@@ -57,5 +59,42 @@ StreamOperatorStateContext streamOperatorStateContext(
 		@Nullable TypeSerializer<?> keySerializer,
 		@Nonnull CloseableRegistry streamTaskCloseableRegistry,
 		@Nonnull MetricGroup metricGroup,
-		double managedMemoryFraction) throws Exception;
+		double managedMemoryFraction,
+		boolean isUsingCustomRawKeyedState) throws Exception;
+
+	/**
+	 * Returns the {@link StreamOperatorStateContext} for an {@link AbstractStreamOperator} that runs in the stream
+	 * task that owns this manager.
+	 *
+	 * @param operatorID the id of the operator for which the context is created. Cannot be null.
+	 * @param operatorClassName the classname of the operator instance for which the context is created. Cannot be null.
+	 * @param processingTimeService
+	 * @param keyContext the key context of the operator instance for which the context is created Cannot be null.
+	 * @param keySerializer the key-serializer for the operator. Can be null.
+	 * @param streamTaskCloseableRegistry the closeable registry to which created closeable objects will be registered.
+	 * @param metricGroup the parent metric group for all statebackend metrics
+	 * @param managedMemoryFraction the managed memory fraction of the operator for state backend
+	 * @return a context from which the given operator can initialize everything related to state.
+	 * @throws Exception when something went wrong while creating the context.
+	 */
+	default StreamOperatorStateContext streamOperatorStateContext(

Review comment:
       +1 for removing the default method. `AbstractStreamOperatorV2` should be changed as well.
   
   `AbstractStreamOperatorV2` is hoped to replace `AbstractStreamOperator` in the long run. Currently there is no production code using `AbstractStreamOperatorV2`, but it's a user facing class, the same way as `AbstractStreamOperator` is. More over, it will be used in production code very shortly: https://issues.apache.org/jira/browse/FLINK-19621




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org