[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5015: Fix deploy-as-is not honoured on upload from local

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on a change in pull request #5015:
URL: https://github.com/apache/cloudstack/pull/5015#discussion_r630723919



##########
File path: server/src/main/java/com/cloud/template/TemplateAdapterBase.java
##########
@@ -358,7 +358,7 @@ public TemplateProfile prepare(GetUploadParamsForTemplateCmd cmd) throws Resourc
                 BooleanUtils.toBoolean(cmd.isFeatured()), BooleanUtils.toBoolean(cmd.isExtractable()), cmd.getFormat(), osTypeId,
                 cmd.getZoneId(), HypervisorType.getType(cmd.getHypervisor()), cmd.getChecksum(),
                 cmd.getTemplateTag(), cmd.getEntityOwnerId(), cmd.getDetails(), BooleanUtils.toBoolean(cmd.isSshKeyEnabled()),
-                BooleanUtils.toBoolean(cmd.isDynamicallyScalable()), BooleanUtils.toBoolean(cmd.isRoutingType()));
+                BooleanUtils.toBoolean(cmd.isDynamicallyScalable()), BooleanUtils.toBoolean(cmd.isRoutingType()), cmd.isDeployAsIs());
         return prepareUploadParamsInternal(params);

Review comment:
       @nvazquez I think we have to pass params.isDeployAsIs() value in prepare() method inside prepareUploadParamsInternal() method. Otherwise I don't see the usage of deployAsIS from UploadParamsBase.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org