You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Raintung Li (JIRA)" <ji...@apache.org> on 2012/11/09 11:10:12 UTC

[jira] [Created] (SOLR-4055) Remove/Reload the collection will occur the thread safe issue.

Raintung Li created SOLR-4055:
---------------------------------

             Summary: Remove/Reload the collection will occur the thread safe issue.
                 Key: SOLR-4055
                 URL: https://issues.apache.org/jira/browse/SOLR-4055
             Project: Solr
          Issue Type: Bug
          Components: SolrCloud
    Affects Versions: 4.0, 4.0-BETA, 4.0-ALPHA
         Environment: Solr cloud
            Reporter: Raintung Li


OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.

In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.

The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495021#comment-13495021 ] 

Commit Tag Bot commented on SOLR-4055:
--------------------------------------

[trunk commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1408134

SOLR-4055: Remove tabs and format to Lucene convention


                
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Raintung Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raintung Li updated SOLR-4055:
------------------------------

    Summary: Remove/Reload the collection has the thread safe issue.  (was: Remove/Reload the collection will occur the thread safe issue.)
    
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505559#comment-13505559 ] 

Commit Tag Bot commented on SOLR-4055:
--------------------------------------

[branch_4x commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1414760

SOLR-4055: clone params for create calls


                
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495016#comment-13495016 ] 

Commit Tag Bot commented on SOLR-4055:
--------------------------------------

[branch_4x commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1408126

SOLR-4055: Fix a thread safety issue with the Collections API that could cause actions to be targeted at the wrong SolrCores.


                
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495022#comment-13495022 ] 

Commit Tag Bot commented on SOLR-4055:
--------------------------------------

[branch_4x commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1408135

SOLR-4055: Remove tabs and format to Lucene convention


                
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller resolved SOLR-4055.
-------------------------------

    Resolution: Fixed

Thanks Raintung!
                
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505549#comment-13505549 ] 

Commit Tag Bot commented on SOLR-4055:
--------------------------------------

[trunk commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1414744

SOLR-4055: clone params for create calls


                
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-4055) Remove/Reload the collection will occur the thread safe issue.

Posted by "Raintung Li (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raintung Li updated SOLR-4055:
------------------------------

    Attachment: patch-4055

the bug patch
                
> Remove/Reload the collection will occur the thread safe issue.
> --------------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller resolved SOLR-4055.
-------------------------------

    Resolution: Fixed
    
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated SOLR-4055:
------------------------------

    Fix Version/s: 5.0
                   4.1
         Assignee: Mark Miller
    
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Reopened] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller reopened SOLR-4055:
-------------------------------


See SOLR-4114 - we missed a spot.
                
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Commit Tag Bot (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495017#comment-13495017 ] 

Commit Tag Bot commented on SOLR-4055:
--------------------------------------

[trunk commit] Mark Robert Miller
http://svn.apache.org/viewvc?view=revision&revision=1408125

SOLR-4055: Fix a thread safety issue with the Collections API that could cause actions to be targeted at the wrong SolrCores.


                
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (SOLR-4055) Remove/Reload the collection has the thread safe issue.

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494942#comment-13494942 ] 

Mark Miller commented on SOLR-4055:
-----------------------------------

Great catch Raintung!
                
> Remove/Reload the collection has the thread safe issue.
> -------------------------------------------------------
>
>                 Key: SOLR-4055
>                 URL: https://issues.apache.org/jira/browse/SOLR-4055
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0-ALPHA, 4.0-BETA, 4.0
>         Environment: Solr cloud
>            Reporter: Raintung Li
>            Assignee: Mark Miller
>             Fix For: 4.1, 5.0
>
>         Attachments: patch-4055
>
>
> OverseerCollectionProcessor class for collectionCmd method has thread safe issue.
> The major issue is ModifiableSolrParams params instance will deliver into other thread use(HttpShardHandler.submit). Modify parameter will affect the other threads the correct parameter.
> In the method collectionCmd , change the value params.set(CoreAdminParams.CORE, node.getStr(ZkStateReader.CORE_NAME_PROP)); , that occur send the http request thread will get the wrong core name. The result is that can't delete/reload the right core.
> The easy fix is clone the ModifiableSolrParams for every request.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org