You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/09 09:49:03 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4213: Add ValueASTNode

terrymanu opened a new pull request #4213: Add ValueASTNode
URL: https://github.com/apache/incubator-shardingsphere/pull/4213
 
 
   For #3914.
   
   - Add ValueASTNode for generic of value node.
   - Use unified interface getValue to get all value of value node.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4213: Add ValueASTNode

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #4213: Add ValueASTNode
URL: https://github.com/apache/incubator-shardingsphere/pull/4213#issuecomment-583827383
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213?src=pr&el=h1) Report
   > Merging [#4213](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f1d82c6f616e9577809e123a7d99948de15b06d8?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4213      +/-   ##
   ============================================
   - Coverage     60.67%   60.67%   -0.01%     
     Complexity      352      352              
   ============================================
     Files          1013     1013              
     Lines         16972    16973       +1     
     Branches       2992     2992              
   ============================================
     Hits          10298    10298              
   - Misses         6022     6023       +1     
     Partials        652      652
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ere/sql/parser/sql/value/impl/CollectionValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvaW1wbC9Db2xsZWN0aW9uVmFsdWUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...dingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxETUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/shardingsphere/sql/parser/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL015U1FMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...dingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxEQUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...gsphere/sql/parser/sql/value/impl/NumberValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvaW1wbC9OdW1iZXJWYWx1ZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...dingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxERExWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...sphere/sql/parser/sql/value/impl/BooleanValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvaW1wbC9Cb29sZWFuVmFsdWUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213?src=pr&el=footer). Last update [f1d82c6...e1c49b2](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4213: Add ValueASTNode

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #4213: Add ValueASTNode
URL: https://github.com/apache/incubator-shardingsphere/pull/4213#issuecomment-583827600
 
 
   ## Pull Request Test Coverage Report for [Build 9397](https://coveralls.io/builds/28614097)
   
   * **0** of **40**   **(0.0%)**  changed or added relevant lines in **7** files are covered.
   * **4** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.01%**) to **64.573%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/impl/NumberValue.java](https://coveralls.io/builds/28614097/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fimpl%2FNumberValue.java#L36) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/impl/CollectionValue.java](https://coveralls.io/builds/28614097/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fimpl%2FCollectionValue.java#L32) | 0 | 3 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28614097/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L60) | 0 | 3 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/impl/BooleanValue.java](https://coveralls.io/builds/28614097/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fimpl%2FBooleanValue.java#L28) | 0 | 5 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28614097/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L124) | 0 | 6 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28614097/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L168) | 0 | 9 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28614097/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L106) | 0 | 12 | 0.0%
   <!-- | **Total:** | **0** | **40** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28614097/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L126) | 1 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28614097/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
   <!-- | **Total:** | **4** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28614097/badge)](https://coveralls.io/builds/28614097) |
   | :-- | --: |
   | Change from base [Build 801](https://coveralls.io/builds/28613880): |  -0.01% |
   | Covered Lines: | 10960 |
   | Relevant Lines: | 16973 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4213: Add ValueASTNode

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #4213: Add ValueASTNode
URL: https://github.com/apache/incubator-shardingsphere/pull/4213#issuecomment-583827600
 
 
   ## Pull Request Test Coverage Report for [Build 1654](https://coveralls.io/builds/28614133)
   
   * **0** of **40**   **(0.0%)**  changed or added relevant lines in **7** files are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage decreased (**-0.004%**) to **64.579%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/impl/NumberValue.java](https://coveralls.io/builds/28614133/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fimpl%2FNumberValue.java#L36) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/impl/CollectionValue.java](https://coveralls.io/builds/28614133/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fimpl%2FCollectionValue.java#L32) | 0 | 3 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28614133/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L60) | 0 | 3 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/impl/BooleanValue.java](https://coveralls.io/builds/28614133/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fimpl%2FBooleanValue.java#L28) | 0 | 5 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28614133/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L124) | 0 | 6 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28614133/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L168) | 0 | 9 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28614133/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L106) | 0 | 12 | 0.0%
   <!-- | **Total:** | **0** | **40** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDDLVisitor.java](https://coveralls.io/builds/28614133/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDDLVisitor.java#L126) | 1 | 0% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28614133/badge)](https://coveralls.io/builds/28614133) |
   | :-- | --: |
   | Change from base [Build 801](https://coveralls.io/builds/28613880): |  -0.004% |
   | Covered Lines: | 10961 |
   | Relevant Lines: | 16973 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4213: Add ValueASTNode

Posted by GitBox <gi...@apache.org>.

tristaZero merged pull request #4213: Add ValueASTNode
URL: https://github.com/apache/incubator-shardingsphere/pull/4213
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services