[GitHub] [airflow] uranusjr commented on a diff in pull request #26993: Fix inconsistent try_counts across logs

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #26993:
URL: https://github.com/apache/airflow/pull/26993#discussion_r1023502912


##########
airflow/www/utils.py:
##########
@@ -440,6 +440,11 @@ def dag_run_link(attr):
     return Markup('<a href="{url}">{run_id}</a>').format(url=url, run_id=run_id)
 
 
+def task_try_count(ti: TaskInstance) -> int:
+    """Get the total try count for a task instance"""
+    return ti._try_number if ti._try_number != 0 or ti.state in State.running else ti._try_number + 1

Review Comment:
   We should add a new property on TaskInstance for this logic. Giving it a good name and documenting both it and `try_number` would help things.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org