[GitHub] [incubator-seatunnel] simon824 commented on a change in pull request #1154: [SeaTunnel #990][FOLLOWUP] Optimize doris connector checkConfig

[GitBox <gi...@apache.org>]

simon824 commented on a change in pull request #1154:
URL: https://github.com/apache/incubator-seatunnel/pull/1154#discussion_r790666391



##########
File path: seatunnel-connectors/seatunnel-connector-spark-doris/src/main/scala/org/apache/seatunnel/spark/sink/Doris.scala
##########
@@ -68,35 +69,23 @@ class Doris extends SparkBatchSink with Serializable {
   }
 
   override def checkConfig(): CheckResult = {
-    val checkResult =
-      checkAllExists(config, Config.HOST, Config.DATABASE, Config.TABLE_NAME, Config.USER, Config.PASSWORD)
+    checkAllExists(config, HOST, DATABASE, TABLE_NAME, USER, PASSWORD)
+  }
 
-    if (!checkResult.isSuccess) {
-      checkResult
-    } else if (config.hasPath(Config.USER) && !config.hasPath(Config.PASSWORD) || config.hasPath(
-        Config.PASSWORD) && !config.hasPath(Config.USER)) {

Review comment:
       This judgement is redundant.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org