[GitHub] [hive] sam-an-cloudera commented on a change in pull request #662: Hive-21787: Metastore table cache enhancement

[GitBox <gi...@apache.org>]

sam-an-cloudera commented on a change in pull request #662: Hive-21787: Metastore table cache enhancement
URL: https://github.com/apache/hive/pull/662#discussion_r292133084
 
 

 ##########
 File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
 ##########
 @@ -120,14 +118,15 @@
   private Configuration conf;
   private static boolean areTxnStatsSupported;
   private PartitionExpressionProxy expressionProxy = null;
+  private static String lock = "L";
+  private static boolean sharedCacheInited = false;
   private static SharedCache sharedCache = new SharedCache();
-  private static  boolean canUseEvents = false;
+  private static boolean canUseEvents = false;
   private static long lastEventId;
 
-  static final private Logger LOG = LoggerFactory.getLogger(CachedStore.class.getName());
+  private static final Logger LOG = LoggerFactory.getLogger(CachedStore.class.getName());
 
-  @Override
-  public void setConf(Configuration conf) {
+  @Override public void setConf(Configuration conf) {
 
 Review comment:
   I think the annotation on same line or do not wrap behavior came from the CheckStyle template I got from the Apache link Thejas sent me. Let me see if I can change the template itself, if not, I will manually correct all the places that they are on same line. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org