[jira] Commented: (IVY-900) Parsing of m2 pom does not handle properties correctly.

["Xavier Hanin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IVY-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629728#action_12629728 ] 

Xavier Hanin commented on IVY-900:
----------------------------------

Thanks for your contribution Kevin, but could you be more precise when you say they aren't fixed? And what exactly your attached file fixes? Something like a junit test failing without the patch and passing with the patch would be helpful. 

Indeed properties are actually loaded in current code, including default properties (but not the exact same ones as you do, some are missing in your code, some may be missing in current code). The main difference I see is the time at which properties are loaded. In current code, loading and setting properties is done after pom coordinates are loaded, so I suspect some cases will fail, for instance when a project.groupId is used to define the artifactId. But we need to be careful also with inherited parent properties, and which one takes precendence. I guess the properties defined in the child should take precedence, but it does not seem to be the case in current Ivy code. In your code, changing getPomProperties() implementation has a side effect which may have bad consequence on this too.

So I think properties loading needs to be reviewed, but your patch is not enough, we need to review how properties are loaded and set more globally.

> Parsing of m2 pom does not handle properties correctly.
> -------------------------------------------------------
>
>                 Key: IVY-900
>                 URL: https://issues.apache.org/jira/browse/IVY-900
>             Project: Ivy
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Kevin Brockhoff
>         Attachments: PomReader.java
>
>
> There are a bunch of issues (IVY-512, IVY-550, IVY-620, IVY-637) that are marked fixed that are not fixed. The attached file will actually fix these issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.