[GitHub] [spark] MaxGekk commented on a change in pull request #32213: [SPARK-35114][SQL][TESTS] Add checks for ANSI intervals to `LiteralExpressionSuite`

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #32213:
URL: https://github.com/apache/spark/pull/32213#discussion_r615344413



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
##########
@@ -200,8 +204,8 @@ class LiteralExpressionSuite extends SparkFunSuite with ExpressionEvalHelper {
     checkSeqLiteral(Seq(1, 2, 3), IntegerType)
     checkSeqLiteral(Seq("a", "b", "c"), StringType)
     checkSeqLiteral(Seq(1.0, 4.0), DoubleType)
-    checkSeqLiteral(Seq(MICROS_PER_DAY, MICROS_PER_HOUR),
-      CalendarIntervalType)

Review comment:
       @maropu I removed it because this doesn't check `CalendarIntervalType`. `elementType` is not used in `checkSeqLiteral()`, and this `checkSeqLiteral(Seq(MICROS_PER_DAY, MICROS_PER_HOUR), CalendarIntervalType)` checks the `Long` type, actually.
   
   I think of to improve the test by removing `elementType` at all, and check `CalendarIntervalType` via `CalendarInterval` values.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org