You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/15 10:24:39 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
RobertIndie opened a new pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243
Fixes #9204
Master Issue: #<xyz>
### Motivation
Currently, in the python and C++ client, the "replicateSubscriptionState" feature can no be enabled in the consumer creation.
### Modifications
Expose the "replicateSubscriptionState" setting in the consumer's construct function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243#issuecomment-820443157
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liguangcheng edited a comment on pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
Posted by GitBox <gi...@apache.org>.
liguangcheng edited a comment on pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243#issuecomment-983523465
Hi all
I see the `replicateSubscriptionState` setting has been exposed in C++ client at version 2.8, have you test if it is work among multi cluster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243#discussion_r613953050
##########
File path: pulsar-client-cpp/lib/ConsumerConfiguration.cc
##########
@@ -163,6 +163,14 @@ void ConsumerConfiguration::setPatternAutoDiscoveryPeriod(int periodInSeconds) {
int ConsumerConfiguration::getPatternAutoDiscoveryPeriod() const { return impl_->patternAutoDiscoveryPeriod; }
+void ConsumerConfiguration::setReplicateSubscriptionState(bool replicateSubscriptionState) {
Review comment:
```suggestion
void ConsumerConfiguration::setReplicateSubscriptionStateEnabled(bool enabled) {
```
##########
File path: pulsar-client-cpp/lib/ConsumerConfiguration.cc
##########
@@ -163,6 +163,14 @@ void ConsumerConfiguration::setPatternAutoDiscoveryPeriod(int periodInSeconds) {
int ConsumerConfiguration::getPatternAutoDiscoveryPeriod() const { return impl_->patternAutoDiscoveryPeriod; }
+void ConsumerConfiguration::setReplicateSubscriptionState(bool replicateSubscriptionState) {
+ impl_->replicateSubscriptionState = replicateSubscriptionState;
+}
+
+bool ConsumerConfiguration::getReplicateSubscriptionState() const {
Review comment:
```suggestion
bool ConsumerConfiguration::isReplicateSubscriptionStateEnabled() const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243#issuecomment-820882546
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243#issuecomment-820319356
@BewareMyPower Please help review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liguangcheng commented on pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
Posted by GitBox <gi...@apache.org>.
liguangcheng commented on pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243#issuecomment-983523465
Hi all
I see the `replicateSubscriptionState` setting has been exposed in C++ client, have you test if it is work among multi cluster?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #10243: [Issue 9204][Python/C++]Expose replicateSubscriptionState setting for python/c++ consumer
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on pull request #10243:
URL: https://github.com/apache/pulsar/pull/10243#issuecomment-845935033
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org