You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mumrah (via GitHub)" <gi...@apache.org> on 2023/06/09 18:42:55 UTC

[GitHub] [kafka] mumrah commented on pull request #13724: MINOR: more KRaft Metadata Image tests

mumrah commented on PR #13724:
URL: https://github.com/apache/kafka/pull/13724#issuecomment-1584996747

   @rondagostino I like the approach you've got here! It will definitely help us cover a lot of edge conditions in the replay and apply logic. 
   
   Do you think we could extend the idea to also vary the size of the batch being applied as we go along?
   
   For example, with 6 records, you have 5 possibilities currently. If we add another dimension (m) to be the size of the batch being applied, you would get a lot more combinations. At n=3 (three initial records) instead of only {A, B, C} {D, E, F}, we would have:
   
   * {A, B, C} {D} {E} {F} (m=1)
   * {A, B, C} {D, E} {F} (m=2)
   * {A, B, C} {D, E, F} (m=3)
   
   that would give us something on the order of N^2 / 2 permutations. 
   
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org