[jira] [Commented] (OAK-1205) Enable/Disable security for ImmutableRoot built from a Root

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827645#comment-13827645 ] 

angela commented on OAK-1205:
-----------------------------

IMO this doesn't make too much sense. the current definition of ImmutableRoot is

{code}
Simple implementation of the Root interface that only supports simple read
 operations based on the {@code NodeState} (or {@code ImmutableTree})
 passed to the constructor. This root implementation provides a query engine
 with index support limited to the {@link PropertyIndexProvider}.
{code}

and the immutabletree is defined to be just a simple wrapper around a NodeState
and the whole thing is intended to be used to get the benefit of the hierarchical information
present with root/tree that is missing with the NodeState API in cases where you don't
care about permission because you are executing system internal operations.

can you please provide more information what's the background of this issue?

> Enable/Disable security for ImmutableRoot built from a Root
> -----------------------------------------------------------
>
>                 Key: OAK-1205
>                 URL: https://issues.apache.org/jira/browse/OAK-1205
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Antonio Sanso
>            Priority: Minor
>         Attachments: OAK1205-patch.txt
>
>
> At the moment  when invoking the 
> {code}
>  public ImmutableRoot(@Nonnull Root root, @Nonnull TreeTypeProvider typeProvider) {
> {code}
> constructor there is no way to specify if to specify if the SecureNodeState should be use or not.
> Indeed with the current implementation this is always disabled. It would be nice to have the explicit choice to have a SecureNodeState or not, e.g. having
> {code}
> public ImmutableRoot(@Nonnull Root root, @Nonnull TreeTypeProvider typeProvider, boolean secured) {
> {code}
>  I have discussed this with [~mduerig] and we came up with the patch I will provide.



--
This message was sent by Atlassian JIRA
(v6.1#6144)