You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2013/09/30 01:25:42 UTC

Review Request 14399: OfflinePartitionCount metrics may be incorrect after the controller failover

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14399/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1068
    https://issues.apache.org/jira/browse/KAFKA-1068


Repository: kafka


Description
-------

kafka-1068


Diffs
-----

  core/src/main/scala/kafka/controller/KafkaController.scala aef41ad5f087817862dcbd9dfbb4674e49e21f91 

Diff: https://reviews.apache.org/r/14399/diff/


Testing
-------


Thanks,

Jun Rao


Re: Review Request 14399: OfflinePartitionCount metrics may be incorrect after the controller failover

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14399/#review26469
-----------------------------------------------------------

Ship it!


Ship It!

- Guozhang Wang


On Sept. 29, 2013, 11:25 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14399/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 11:25 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1068
>     https://issues.apache.org/jira/browse/KAFKA-1068
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1068
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/controller/KafkaController.scala aef41ad5f087817862dcbd9dfbb4674e49e21f91 
> 
> Diff: https://reviews.apache.org/r/14399/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>


Re: Review Request 14399: OfflinePartitionCount metrics may be incorrect after the controller failover

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14399/#review26489
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On Sept. 29, 2013, 11:25 p.m., Jun Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14399/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 11:25 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1068
>     https://issues.apache.org/jira/browse/KAFKA-1068
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> kafka-1068
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/controller/KafkaController.scala aef41ad5f087817862dcbd9dfbb4674e49e21f91 
> 
> Diff: https://reviews.apache.org/r/14399/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jun Rao
> 
>