You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/10/16 06:50:33 UTC
Review Request 26800: Added a protobuf::append test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26800/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
See summary. Will move the tests to stout in a later patch.
Diffs
-----
src/tests/protobuf_io_tests.cpp 5f80c04fa081d2cbc8782cdf005748e4da04bcf7
Diff: https://reviews.apache.org/r/26800/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 26800: Added a protobuf::append test.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26800/#review56961
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 16, 2014, 4:50 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26800/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 4:50 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. Will move the tests to stout in a later patch.
>
>
> Diffs
> -----
>
> src/tests/protobuf_io_tests.cpp 5f80c04fa081d2cbc8782cdf005748e4da04bcf7
>
> Diff: https://reviews.apache.org/r/26800/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 26800: Added a protobuf::append test.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26800/#review56907
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26715, 26799, 26800]
All tests passed.
- Mesos ReviewBot
On Oct. 16, 2014, 4:50 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26800/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 4:50 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. Will move the tests to stout in a later patch.
>
>
> Diffs
> -----
>
> src/tests/protobuf_io_tests.cpp 5f80c04fa081d2cbc8782cdf005748e4da04bcf7
>
> Diff: https://reviews.apache.org/r/26800/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>