[GitHub] [apisix] spacewander commented on a change in pull request #5257: fix: etcd upgrade 1.6.0 after init back round robin

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #5257:
URL: https://github.com/apache/apisix/pull/5257#discussion_r730596333



##########
File path: apisix/core/config_etcd.lua
##########
@@ -518,7 +518,7 @@ local function _automatic_fetch(premature, self)
         return
     end
 
-    if not health_check.conf then
+    if not health_check.conf or not health_check.conf.shm_name then

Review comment:
       ```suggestion
       if not (health_check.conf and health_check.conf.shm_name) then
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org