[GitHub] [maven-scm] arturobernalg commented on a change in pull request #122: Replace assert by simpler but equivalent calls.

[GitBox <gi...@apache.org>]

arturobernalg commented on a change in pull request #122:
URL: https://github.com/apache/maven-scm/pull/122#discussion_r700735341



##########
File path: maven-scm-providers/maven-scm-providers-cvs/maven-scm-provider-cvs-commons/src/test/java/org/apache/maven/scm/provider/cvslib/command/changelog/CvsChangeLogConsumerTest.java
##########
@@ -71,8 +71,8 @@ public void testParse()
         for ( Iterator<ChangeSet> i = entries.iterator(); i.hasNext(); )
         {
             entry = i.next();
-            assertTrue( "ChangeLogEntry erroneously picked up",
-                        entry.toString().indexOf( "ChangeLogEntry.java" ) == -1 );
+            assertEquals( "ChangeLogEntry erroneously picked up",

Review comment:
       Revert it

##########
File path: maven-scm-providers/maven-scm-provider-starteam/src/test/java/org/apache/maven/scm/provider/starteam/command/changelog/StarteamChangeLogConsumerTest.java
##########
@@ -77,8 +77,8 @@ public void testNumberOfModifications()
 
         for ( Iterator<ChangeSet> i = entries.iterator(); i.hasNext(); )
         {
-            assertTrue( "ChangeLogEntry erroneously picked up",
-                        i.next().toString().indexOf( "ChangeLogEntry.java" ) == -1 );
+            assertEquals( "ChangeLogEntry erroneously picked up",
+                    -1, i.next().toString().indexOf("ChangeLogEntry.java") );

Review comment:
       Revert it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org