You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/06/04 01:11:00 UTC

[jira] [Commented] (HBASE-24309) Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

    [ https://issues.apache.org/jira/browse/HBASE-24309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125448#comment-17125448 ] 

Hudson commented on HBASE-24309:
--------------------------------

Results for branch branch-2
	[build #2689 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2689/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-24309
>                 URL: https://issues.apache.org/jira/browse/HBASE-24309
>             Project: HBase
>          Issue Type: Sub-task
>          Components: logging, pom
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> In general, a library should not force the down stream users to use a specific logging framework, and this is why there is a slf4j library.
> For HBase, since we also publish the testing-util module which almost depends on all other sub modules, we should not introduce logging dependencies other than slf4j-api in these modules. We should only add log4j dependencies in hbase-assembly and ship it with our binary distribution.
> This is also important for switching to log4j2.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)