You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@grails.apache.org by James Daugherty <jd...@apache.org> on 2025/07/02 11:38:52 UTC

[DISCUSS] - Grails 7 & Reverting Sitemesh 3

Hi Everyone,

I started investigating a ticket related to forwarding not working in a
Grails controller on 7.0.0-M4.  As part of that I made this discovery:
https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
 It seems the DispatcherServlet from Spring is designed to handle multiple
calls methods that cause the response to render and close.  The dispatcher
chooses  the right one by the committed state of the response.

From my investigation, the Sitemesh 3 implementation appears to use a
filter to render its output after the DispatcherServlet is processed - so
the response state is never committed.  I think we could update the
GrailsDispatcherServlet to handle the various scenarios that the
DispatcherServlet handles, but I'm not sure this is practical for Grails 7
given the delays we have already had.  We would also be deviating from how
Spring MVC controllers are rendered and this logic doesn't appear that
simple.  Moreover, we still have several outstanding tickets related to the
sitemesh 3 upgrade:

* Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
forwarding from a controller
* Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
layouts
* Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw in
titles
* Nov 2024 - https://github.com/apache/grails-core/issues/13849 - layout by
convention

We have reached out to the developer of Sitemesh 3 on most of these tickets
(via ticket comments and direct slack messages over the past few months);
we have yet to receive any work or progress on them. The oldest of which is
8+ months old. I'm skeptical these can be finished in a reasonable time
frame.


Given the lack of support, the multiple issues found by users, and the
current state of Grails 7 being delayed by these tickets, I would like to
propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of these
issues are fixed, we would only have the remaining license, asset plugin
release, & ASF release related issues to fix before we could release Grails
7.


I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
branch (https://github.com/apache/grails-core/tree/issue14193).  As part of
switching back to v2, I discovered the following is now fixed:
* async rendering
* async error handling
* layout specified by a controller property
* layout specified in controller property applied to a GSP that does not
contain a root html tag

It seems the sitemesh3 upgrade was performed during a time when the project
wasn't running all of its tests, so we are only now learning the scope of
its impact.  I think we can still be open to switching to Sitemesh 3 in
Grails 8.  Especially if we get the necessary support, but otherwise, we
can continue with 2.x.

Please note as part of this branch revert, I've also taken a closer look at
the Sitemesh licensing requirements and made a first pass being compatible
with the Sitemesh license.  We'll still have to follow-up with ASF legal to
ensure we're compliant since the license is a derivative of the ASF
license.

-James

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by James Daugherty <jd...@apache.org>.
FYI: Legal responded saying treat it as Apache 1.1, so we should be good on the license question.

On 2025/07/03 22:32:46 James Daugherty wrote:
> FYI: I opened https://issues.apache.org/jira/browse/LEGAL-707 for the license question.  Although, struts used it up until last year, so I assume it's acceptable.
> 
> On 2025/07/02 11:38:52 James Daugherty wrote:
> > Hi Everyone,
> > 
> > I started investigating a ticket related to forwarding not working in a
> > Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> > https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> >  It seems the DispatcherServlet from Spring is designed to handle multiple
> > calls methods that cause the response to render and close.  The dispatcher
> > chooses  the right one by the committed state of the response.
> > 
> > From my investigation, the Sitemesh 3 implementation appears to use a
> > filter to render its output after the DispatcherServlet is processed - so
> > the response state is never committed.  I think we could update the
> > GrailsDispatcherServlet to handle the various scenarios that the
> > DispatcherServlet handles, but I'm not sure this is practical for Grails 7
> > given the delays we have already had.  We would also be deviating from how
> > Spring MVC controllers are rendered and this logic doesn't appear that
> > simple.  Moreover, we still have several outstanding tickets related to the
> > sitemesh 3 upgrade:
> > 
> > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > forwarding from a controller
> > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> > layouts
> > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw in
> > titles
> > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 - layout by
> > convention
> > 
> > We have reached out to the developer of Sitemesh 3 on most of these tickets
> > (via ticket comments and direct slack messages over the past few months);
> > we have yet to receive any work or progress on them. The oldest of which is
> > 8+ months old. I'm skeptical these can be finished in a reasonable time
> > frame.
> > 
> > 
> > Given the lack of support, the multiple issues found by users, and the
> > current state of Grails 7 being delayed by these tickets, I would like to
> > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of these
> > issues are fixed, we would only have the remaining license, asset plugin
> > release, & ASF release related issues to fix before we could release Grails
> > 7.
> > 
> > 
> > I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> > branch (https://github.com/apache/grails-core/tree/issue14193).  As part of
> > switching back to v2, I discovered the following is now fixed:
> > * async rendering
> > * async error handling
> > * layout specified by a controller property
> > * layout specified in controller property applied to a GSP that does not
> > contain a root html tag
> > 
> > It seems the sitemesh3 upgrade was performed during a time when the project
> > wasn't running all of its tests, so we are only now learning the scope of
> > its impact.  I think we can still be open to switching to Sitemesh 3 in
> > Grails 8.  Especially if we get the necessary support, but otherwise, we
> > can continue with 2.x.
> > 
> > Please note as part of this branch revert, I've also taken a closer look at
> > the Sitemesh licensing requirements and made a first pass being compatible
> > with the Sitemesh license.  We'll still have to follow-up with ASF legal to
> > ensure we're compliant since the license is a derivative of the ASF
> > license.
> > 
> > -James
> > 
> 

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by Andrew Garcia <an...@goodshuffle.com.INVALID>.
Agreed, that was an elegant maneuver.

On Fri, Jul 11, 2025 at 3:52 AM Søren Berg Glasius <so...@glasius.dk>
wrote:

> @James Daugherty <jd...@jdresources.net> Awesome piece of work (as
> always).
>
> And I'm happy that SiteMesh3 is still in play!
>
> Den fre. 11. jul. 2025 kl. 05.12 skrev Scott Murphy Heiberg <
> scottheiberg@apache.org>:
>
> > I would say that considering now both are supported, there is no urgency
> > in fixing the sitemesh 3 issues.  It is totally fine if you address the
> > micronaut test apps and metadata issues first.
> >
> > All I cared about is that the sitemesh 3 plugin could continue to evolve
> > and be used and I feel like you have made that a possibility.
> >
> > Thanks!
> >
> > On 2025/07/10 17:54:09 James Daugherty wrote:
> > > FYI: https://github.com/apache/grails-core/pull/14891 is the PR that
> > will
> > > restore the choice of using either Sitemesh3 or Sitemesh2 with Grails
> 7.
> > >
> > > @Scott, given that this functionality makes 7 equivalent to what it was
> > > before the M4 and it's fully decoupled, do we need to resolve the
> > Sitemesh3
> > > issues immediately?  I'm traveling next week, and would like to address
> > the
> > > micronaut test apps & metadata issues since they're more critical to
> the
> > > Grails 7 final release.  My hope is we could fix sitemesh3 related
> issues
> > > as time permits from working on the Grails 7 blockers.
> > >
> > > On Thu, Jul 3, 2025 at 6:32 PM James Daugherty <jd...@apache.org>
> > > wrote:
> > >
> > > > FYI: I opened https://issues.apache.org/jira/browse/LEGAL-707 for
> the
> > > > license question.  Although, struts used it up until last year, so I
> > assume
> > > > it's acceptable.
> > > >
> > > > On 2025/07/02 11:38:52 James Daugherty wrote:
> > > > > Hi Everyone,
> > > > >
> > > > > I started investigating a ticket related to forwarding not working
> > in a
> > > > > Grails controller on 7.0.0-M4.  As part of that I made this
> > discovery:
> > > > >
> > > >
> >
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> > > > >  It seems the DispatcherServlet from Spring is designed to handle
> > > > multiple
> > > > > calls methods that cause the response to render and close.  The
> > > > dispatcher
> > > > > chooses  the right one by the committed state of the response.
> > > > >
> > > > > From my investigation, the Sitemesh 3 implementation appears to
> use a
> > > > > filter to render its output after the DispatcherServlet is
> processed
> > - so
> > > > > the response state is never committed.  I think we could update the
> > > > > GrailsDispatcherServlet to handle the various scenarios that the
> > > > > DispatcherServlet handles, but I'm not sure this is practical for
> > Grails
> > > > 7
> > > > > given the delays we have already had.  We would also be deviating
> > from
> > > > how
> > > > > Spring MVC controllers are rendered and this logic doesn't appear
> > that
> > > > > simple.  Moreover, we still have several outstanding tickets
> related
> > to
> > > > the
> > > > > sitemesh 3 upgrade:
> > > > >
> > > > > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > > > > forwarding from a controller
> > > > > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 -
> > nested
> > > > > layouts
> > > > > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 -
> > $raw
> > > > in
> > > > > titles
> > > > > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 -
> > > > layout by
> > > > > convention
> > > > >
> > > > > We have reached out to the developer of Sitemesh 3 on most of these
> > > > tickets
> > > > > (via ticket comments and direct slack messages over the past few
> > months);
> > > > > we have yet to receive any work or progress on them. The oldest of
> > which
> > > > is
> > > > > 8+ months old. I'm skeptical these can be finished in a reasonable
> > time
> > > > > frame.
> > > > >
> > > > >
> > > > > Given the lack of support, the multiple issues found by users, and
> > the
> > > > > current state of Grails 7 being delayed by these tickets, I would
> > like to
> > > > > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all
> of
> > > > these
> > > > > issues are fixed, we would only have the remaining license, asset
> > plugin
> > > > > release, & ASF release related issues to fix before we could
> release
> > > > Grails
> > > > > 7.
> > > > >
> > > > >
> > > > > I have gone ahead and reverted back to Sitemesh 2.6.0 in the
> > issue14193
> > > > > branch (https://github.com/apache/grails-core/tree/issue14193).
> As
> > > > part of
> > > > > switching back to v2, I discovered the following is now fixed:
> > > > > * async rendering
> > > > > * async error handling
> > > > > * layout specified by a controller property
> > > > > * layout specified in controller property applied to a GSP that
> does
> > not
> > > > > contain a root html tag
> > > > >
> > > > > It seems the sitemesh3 upgrade was performed during a time when the
> > > > project
> > > > > wasn't running all of its tests, so we are only now learning the
> > scope of
> > > > > its impact.  I think we can still be open to switching to Sitemesh
> 3
> > in
> > > > > Grails 8.  Especially if we get the necessary support, but
> > otherwise, we
> > > > > can continue with 2.x.
> > > > >
> > > > > Please note as part of this branch revert, I've also taken a closer
> > look
> > > > at
> > > > > the Sitemesh licensing requirements and made a first pass being
> > > > compatible
> > > > > with the Sitemesh license.  We'll still have to follow-up with ASF
> > legal
> > > > to
> > > > > ensure we're compliant since the license is a derivative of the ASF
> > > > > license.
> > > > >
> > > > > -James
> > > > >
> > > >
> > >
> >
>
>
> --
>
> Med venlig hilsen,
> Søren Berg Glasius
>
> Hedevej 1, Gl. Rye, 8680 Ry
> Mobile: +45 40 44 91 88
> --- Press ESC once to quit - twice to save the changes.
>


-- 

*Andrew Garcia* | Co-Founder & CEO
andrew@goodshuffle.com

*Goodshuffle Pro*
<https://pro.goodshuffle.com/?utm_source=goodshuffle&utm_medium=email&utm_campaign=employeesignature&fbid=emailsignaturehomepage>
 | Read our reviews on Capterra
<https://www.capterra.com/p/167364/Goodshuffle-Pro/reviews/>

<https://www.facebook.com/Goodshuffle/>
<https://www.instagram.com/goodshuffle/>
<https://www.linkedin.com/company/goodshuffle/posts/?feedView=all>
<https://www.youtube.com/c/GoodshufflePro>

<https://pro.goodshuffle.com/dispatch-lp?utm_source=goodshuffle&utm_medium=referral&utm_campaign=Feature_Release>

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by Søren Berg Glasius <so...@glasius.dk>.
@James Daugherty <jd...@jdresources.net> Awesome piece of work (as
always).

And I'm happy that SiteMesh3 is still in play!

Den fre. 11. jul. 2025 kl. 05.12 skrev Scott Murphy Heiberg <
scottheiberg@apache.org>:

> I would say that considering now both are supported, there is no urgency
> in fixing the sitemesh 3 issues.  It is totally fine if you address the
> micronaut test apps and metadata issues first.
>
> All I cared about is that the sitemesh 3 plugin could continue to evolve
> and be used and I feel like you have made that a possibility.
>
> Thanks!
>
> On 2025/07/10 17:54:09 James Daugherty wrote:
> > FYI: https://github.com/apache/grails-core/pull/14891 is the PR that
> will
> > restore the choice of using either Sitemesh3 or Sitemesh2 with Grails 7.
> >
> > @Scott, given that this functionality makes 7 equivalent to what it was
> > before the M4 and it's fully decoupled, do we need to resolve the
> Sitemesh3
> > issues immediately?  I'm traveling next week, and would like to address
> the
> > micronaut test apps & metadata issues since they're more critical to the
> > Grails 7 final release.  My hope is we could fix sitemesh3 related issues
> > as time permits from working on the Grails 7 blockers.
> >
> > On Thu, Jul 3, 2025 at 6:32 PM James Daugherty <jd...@apache.org>
> > wrote:
> >
> > > FYI: I opened https://issues.apache.org/jira/browse/LEGAL-707 for the
> > > license question.  Although, struts used it up until last year, so I
> assume
> > > it's acceptable.
> > >
> > > On 2025/07/02 11:38:52 James Daugherty wrote:
> > > > Hi Everyone,
> > > >
> > > > I started investigating a ticket related to forwarding not working
> in a
> > > > Grails controller on 7.0.0-M4.  As part of that I made this
> discovery:
> > > >
> > >
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> > > >  It seems the DispatcherServlet from Spring is designed to handle
> > > multiple
> > > > calls methods that cause the response to render and close.  The
> > > dispatcher
> > > > chooses  the right one by the committed state of the response.
> > > >
> > > > From my investigation, the Sitemesh 3 implementation appears to use a
> > > > filter to render its output after the DispatcherServlet is processed
> - so
> > > > the response state is never committed.  I think we could update the
> > > > GrailsDispatcherServlet to handle the various scenarios that the
> > > > DispatcherServlet handles, but I'm not sure this is practical for
> Grails
> > > 7
> > > > given the delays we have already had.  We would also be deviating
> from
> > > how
> > > > Spring MVC controllers are rendered and this logic doesn't appear
> that
> > > > simple.  Moreover, we still have several outstanding tickets related
> to
> > > the
> > > > sitemesh 3 upgrade:
> > > >
> > > > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > > > forwarding from a controller
> > > > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 -
> nested
> > > > layouts
> > > > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 -
> $raw
> > > in
> > > > titles
> > > > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 -
> > > layout by
> > > > convention
> > > >
> > > > We have reached out to the developer of Sitemesh 3 on most of these
> > > tickets
> > > > (via ticket comments and direct slack messages over the past few
> months);
> > > > we have yet to receive any work or progress on them. The oldest of
> which
> > > is
> > > > 8+ months old. I'm skeptical these can be finished in a reasonable
> time
> > > > frame.
> > > >
> > > >
> > > > Given the lack of support, the multiple issues found by users, and
> the
> > > > current state of Grails 7 being delayed by these tickets, I would
> like to
> > > > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of
> > > these
> > > > issues are fixed, we would only have the remaining license, asset
> plugin
> > > > release, & ASF release related issues to fix before we could release
> > > Grails
> > > > 7.
> > > >
> > > >
> > > > I have gone ahead and reverted back to Sitemesh 2.6.0 in the
> issue14193
> > > > branch (https://github.com/apache/grails-core/tree/issue14193).  As
> > > part of
> > > > switching back to v2, I discovered the following is now fixed:
> > > > * async rendering
> > > > * async error handling
> > > > * layout specified by a controller property
> > > > * layout specified in controller property applied to a GSP that does
> not
> > > > contain a root html tag
> > > >
> > > > It seems the sitemesh3 upgrade was performed during a time when the
> > > project
> > > > wasn't running all of its tests, so we are only now learning the
> scope of
> > > > its impact.  I think we can still be open to switching to Sitemesh 3
> in
> > > > Grails 8.  Especially if we get the necessary support, but
> otherwise, we
> > > > can continue with 2.x.
> > > >
> > > > Please note as part of this branch revert, I've also taken a closer
> look
> > > at
> > > > the Sitemesh licensing requirements and made a first pass being
> > > compatible
> > > > with the Sitemesh license.  We'll still have to follow-up with ASF
> legal
> > > to
> > > > ensure we're compliant since the license is a derivative of the ASF
> > > > license.
> > > >
> > > > -James
> > > >
> > >
> >
>


-- 

Med venlig hilsen,
Søren Berg Glasius

Hedevej 1, Gl. Rye, 8680 Ry
Mobile: +45 40 44 91 88
--- Press ESC once to quit - twice to save the changes.

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by Scott Murphy Heiberg <sc...@apache.org>.
I would say that considering now both are supported, there is no urgency in fixing the sitemesh 3 issues.  It is totally fine if you address the micronaut test apps and metadata issues first.

All I cared about is that the sitemesh 3 plugin could continue to evolve and be used and I feel like you have made that a possibility. 

Thanks!

On 2025/07/10 17:54:09 James Daugherty wrote:
> FYI: https://github.com/apache/grails-core/pull/14891 is the PR that will
> restore the choice of using either Sitemesh3 or Sitemesh2 with Grails 7.
> 
> @Scott, given that this functionality makes 7 equivalent to what it was
> before the M4 and it's fully decoupled, do we need to resolve the Sitemesh3
> issues immediately?  I'm traveling next week, and would like to address the
> micronaut test apps & metadata issues since they're more critical to the
> Grails 7 final release.  My hope is we could fix sitemesh3 related issues
> as time permits from working on the Grails 7 blockers.
> 
> On Thu, Jul 3, 2025 at 6:32 PM James Daugherty <jd...@apache.org>
> wrote:
> 
> > FYI: I opened https://issues.apache.org/jira/browse/LEGAL-707 for the
> > license question.  Although, struts used it up until last year, so I assume
> > it's acceptable.
> >
> > On 2025/07/02 11:38:52 James Daugherty wrote:
> > > Hi Everyone,
> > >
> > > I started investigating a ticket related to forwarding not working in a
> > > Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> > >
> > https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> > >  It seems the DispatcherServlet from Spring is designed to handle
> > multiple
> > > calls methods that cause the response to render and close.  The
> > dispatcher
> > > chooses  the right one by the committed state of the response.
> > >
> > > From my investigation, the Sitemesh 3 implementation appears to use a
> > > filter to render its output after the DispatcherServlet is processed - so
> > > the response state is never committed.  I think we could update the
> > > GrailsDispatcherServlet to handle the various scenarios that the
> > > DispatcherServlet handles, but I'm not sure this is practical for Grails
> > 7
> > > given the delays we have already had.  We would also be deviating from
> > how
> > > Spring MVC controllers are rendered and this logic doesn't appear that
> > > simple.  Moreover, we still have several outstanding tickets related to
> > the
> > > sitemesh 3 upgrade:
> > >
> > > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > > forwarding from a controller
> > > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> > > layouts
> > > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw
> > in
> > > titles
> > > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 -
> > layout by
> > > convention
> > >
> > > We have reached out to the developer of Sitemesh 3 on most of these
> > tickets
> > > (via ticket comments and direct slack messages over the past few months);
> > > we have yet to receive any work or progress on them. The oldest of which
> > is
> > > 8+ months old. I'm skeptical these can be finished in a reasonable time
> > > frame.
> > >
> > >
> > > Given the lack of support, the multiple issues found by users, and the
> > > current state of Grails 7 being delayed by these tickets, I would like to
> > > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of
> > these
> > > issues are fixed, we would only have the remaining license, asset plugin
> > > release, & ASF release related issues to fix before we could release
> > Grails
> > > 7.
> > >
> > >
> > > I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> > > branch (https://github.com/apache/grails-core/tree/issue14193).  As
> > part of
> > > switching back to v2, I discovered the following is now fixed:
> > > * async rendering
> > > * async error handling
> > > * layout specified by a controller property
> > > * layout specified in controller property applied to a GSP that does not
> > > contain a root html tag
> > >
> > > It seems the sitemesh3 upgrade was performed during a time when the
> > project
> > > wasn't running all of its tests, so we are only now learning the scope of
> > > its impact.  I think we can still be open to switching to Sitemesh 3 in
> > > Grails 8.  Especially if we get the necessary support, but otherwise, we
> > > can continue with 2.x.
> > >
> > > Please note as part of this branch revert, I've also taken a closer look
> > at
> > > the Sitemesh licensing requirements and made a first pass being
> > compatible
> > > with the Sitemesh license.  We'll still have to follow-up with ASF legal
> > to
> > > ensure we're compliant since the license is a derivative of the ASF
> > > license.
> > >
> > > -James
> > >
> >
> 

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by James Daugherty <jd...@apache.org>.
FYI: https://github.com/apache/grails-core/pull/14891 is the PR that will
restore the choice of using either Sitemesh3 or Sitemesh2 with Grails 7.

@Scott, given that this functionality makes 7 equivalent to what it was
before the M4 and it's fully decoupled, do we need to resolve the Sitemesh3
issues immediately?  I'm traveling next week, and would like to address the
micronaut test apps & metadata issues since they're more critical to the
Grails 7 final release.  My hope is we could fix sitemesh3 related issues
as time permits from working on the Grails 7 blockers.

On Thu, Jul 3, 2025 at 6:32 PM James Daugherty <jd...@apache.org>
wrote:

> FYI: I opened https://issues.apache.org/jira/browse/LEGAL-707 for the
> license question.  Although, struts used it up until last year, so I assume
> it's acceptable.
>
> On 2025/07/02 11:38:52 James Daugherty wrote:
> > Hi Everyone,
> >
> > I started investigating a ticket related to forwarding not working in a
> > Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> >
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> >  It seems the DispatcherServlet from Spring is designed to handle
> multiple
> > calls methods that cause the response to render and close.  The
> dispatcher
> > chooses  the right one by the committed state of the response.
> >
> > From my investigation, the Sitemesh 3 implementation appears to use a
> > filter to render its output after the DispatcherServlet is processed - so
> > the response state is never committed.  I think we could update the
> > GrailsDispatcherServlet to handle the various scenarios that the
> > DispatcherServlet handles, but I'm not sure this is practical for Grails
> 7
> > given the delays we have already had.  We would also be deviating from
> how
> > Spring MVC controllers are rendered and this logic doesn't appear that
> > simple.  Moreover, we still have several outstanding tickets related to
> the
> > sitemesh 3 upgrade:
> >
> > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > forwarding from a controller
> > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> > layouts
> > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw
> in
> > titles
> > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 -
> layout by
> > convention
> >
> > We have reached out to the developer of Sitemesh 3 on most of these
> tickets
> > (via ticket comments and direct slack messages over the past few months);
> > we have yet to receive any work or progress on them. The oldest of which
> is
> > 8+ months old. I'm skeptical these can be finished in a reasonable time
> > frame.
> >
> >
> > Given the lack of support, the multiple issues found by users, and the
> > current state of Grails 7 being delayed by these tickets, I would like to
> > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of
> these
> > issues are fixed, we would only have the remaining license, asset plugin
> > release, & ASF release related issues to fix before we could release
> Grails
> > 7.
> >
> >
> > I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> > branch (https://github.com/apache/grails-core/tree/issue14193).  As
> part of
> > switching back to v2, I discovered the following is now fixed:
> > * async rendering
> > * async error handling
> > * layout specified by a controller property
> > * layout specified in controller property applied to a GSP that does not
> > contain a root html tag
> >
> > It seems the sitemesh3 upgrade was performed during a time when the
> project
> > wasn't running all of its tests, so we are only now learning the scope of
> > its impact.  I think we can still be open to switching to Sitemesh 3 in
> > Grails 8.  Especially if we get the necessary support, but otherwise, we
> > can continue with 2.x.
> >
> > Please note as part of this branch revert, I've also taken a closer look
> at
> > the Sitemesh licensing requirements and made a first pass being
> compatible
> > with the Sitemesh license.  We'll still have to follow-up with ASF legal
> to
> > ensure we're compliant since the license is a derivative of the ASF
> > license.
> >
> > -James
> >
>

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by James Daugherty <jd...@apache.org>.
FYI: I opened https://issues.apache.org/jira/browse/LEGAL-707 for the license question.  Although, struts used it up until last year, so I assume it's acceptable.

On 2025/07/02 11:38:52 James Daugherty wrote:
> Hi Everyone,
> 
> I started investigating a ticket related to forwarding not working in a
> Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
>  It seems the DispatcherServlet from Spring is designed to handle multiple
> calls methods that cause the response to render and close.  The dispatcher
> chooses  the right one by the committed state of the response.
> 
> From my investigation, the Sitemesh 3 implementation appears to use a
> filter to render its output after the DispatcherServlet is processed - so
> the response state is never committed.  I think we could update the
> GrailsDispatcherServlet to handle the various scenarios that the
> DispatcherServlet handles, but I'm not sure this is practical for Grails 7
> given the delays we have already had.  We would also be deviating from how
> Spring MVC controllers are rendered and this logic doesn't appear that
> simple.  Moreover, we still have several outstanding tickets related to the
> sitemesh 3 upgrade:
> 
> * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> forwarding from a controller
> * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> layouts
> * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw in
> titles
> * Nov 2024 - https://github.com/apache/grails-core/issues/13849 - layout by
> convention
> 
> We have reached out to the developer of Sitemesh 3 on most of these tickets
> (via ticket comments and direct slack messages over the past few months);
> we have yet to receive any work or progress on them. The oldest of which is
> 8+ months old. I'm skeptical these can be finished in a reasonable time
> frame.
> 
> 
> Given the lack of support, the multiple issues found by users, and the
> current state of Grails 7 being delayed by these tickets, I would like to
> propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of these
> issues are fixed, we would only have the remaining license, asset plugin
> release, & ASF release related issues to fix before we could release Grails
> 7.
> 
> 
> I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> branch (https://github.com/apache/grails-core/tree/issue14193).  As part of
> switching back to v2, I discovered the following is now fixed:
> * async rendering
> * async error handling
> * layout specified by a controller property
> * layout specified in controller property applied to a GSP that does not
> contain a root html tag
> 
> It seems the sitemesh3 upgrade was performed during a time when the project
> wasn't running all of its tests, so we are only now learning the scope of
> its impact.  I think we can still be open to switching to Sitemesh 3 in
> Grails 8.  Especially if we get the necessary support, but otherwise, we
> can continue with 2.x.
> 
> Please note as part of this branch revert, I've also taken a closer look at
> the Sitemesh licensing requirements and made a first pass being compatible
> with the Sitemesh license.  We'll still have to follow-up with ASF legal to
> ensure we're compliant since the license is a derivative of the ASF
> license.
> 
> -James
> 

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by Scott Murphy Heiberg <sc...@apache.org>.
It sounds like all these issues have workarounds. I am not sure if it really warrants coupling Grails 7 back to using abandoned sitemesh 2 code from 2009 (that's 16 years ago!)

My schedule frees up in 2 weeks. I am pretty sure I could fix any outstanding bugs at that time.

On 2025/07/02 17:34:10 James Daugherty wrote:
> Thanks Scott for responding. We're not against Sitemesh 3, but we need your
> help to fix these issues and we don't think we can get that done in a
> timely manner.  Some of those tickets have been open for 8 months.
> 
> As for Sitemesh 2.6.0, if the intention is to never release it going
> forward, we had discussed forking it into the grails project.  This will be
> especially important if you think there won't be maintenance on it.
> 
> As for adopting Sitemesh 2.7.0, I noticed the buffer changes in 2.7.0 and
> we would have to make it further compatible with 7 to adopt the latest
> release.  If you can help us with these compatibility issues, we're happy
> to adopt in the shorter term.
> 
> Our main issue is getting Grails 7 released though and the community
> feedback we've received is there are too many issues to keep delaying
> Grails 7.
> 
> -James
> 
> On Wed, Jul 2, 2025 at 1:26 PM Scott Murphy Heiberg <sc...@apache.org>
> wrote:
> 
> > Sitemesh 3 was a complete rewrite that dramatically reduced the complexity
> > of the rendering process.  It was also the introduction of the Apache 2
> > license.  I would recommend just submitting a PR to Sitemesh 3 with
> > whatever fixes are needed.
> >
> > Sitemesh 2.6.0 was never meant to be a replacement for anything and was
> > just a quick patch for a codebase abandoned in 2009. It is a forked release
> > with no future.
> >
> > If you were to revert to Sitemesh 2, the proper course would be to use
> > Sitemesh 2.7.x
> >
> > On 2025/07/02 11:38:52 James Daugherty wrote:
> > > Hi Everyone,
> > >
> > > I started investigating a ticket related to forwarding not working in a
> > > Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> > >
> > https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> > >  It seems the DispatcherServlet from Spring is designed to handle
> > multiple
> > > calls methods that cause the response to render and close.  The
> > dispatcher
> > > chooses  the right one by the committed state of the response.
> > >
> > > From my investigation, the Sitemesh 3 implementation appears to use a
> > > filter to render its output after the DispatcherServlet is processed - so
> > > the response state is never committed.  I think we could update the
> > > GrailsDispatcherServlet to handle the various scenarios that the
> > > DispatcherServlet handles, but I'm not sure this is practical for Grails
> > 7
> > > given the delays we have already had.  We would also be deviating from
> > how
> > > Spring MVC controllers are rendered and this logic doesn't appear that
> > > simple.  Moreover, we still have several outstanding tickets related to
> > the
> > > sitemesh 3 upgrade:
> > >
> > > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > > forwarding from a controller
> > > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> > > layouts
> > > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw
> > in
> > > titles
> > > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 -
> > layout by
> > > convention
> > >
> > > We have reached out to the developer of Sitemesh 3 on most of these
> > tickets
> > > (via ticket comments and direct slack messages over the past few months);
> > > we have yet to receive any work or progress on them. The oldest of which
> > is
> > > 8+ months old. I'm skeptical these can be finished in a reasonable time
> > > frame.
> > >
> > >
> > > Given the lack of support, the multiple issues found by users, and the
> > > current state of Grails 7 being delayed by these tickets, I would like to
> > > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of
> > these
> > > issues are fixed, we would only have the remaining license, asset plugin
> > > release, & ASF release related issues to fix before we could release
> > Grails
> > > 7.
> > >
> > >
> > > I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> > > branch (https://github.com/apache/grails-core/tree/issue14193).  As
> > part of
> > > switching back to v2, I discovered the following is now fixed:
> > > * async rendering
> > > * async error handling
> > > * layout specified by a controller property
> > > * layout specified in controller property applied to a GSP that does not
> > > contain a root html tag
> > >
> > > It seems the sitemesh3 upgrade was performed during a time when the
> > project
> > > wasn't running all of its tests, so we are only now learning the scope of
> > > its impact.  I think we can still be open to switching to Sitemesh 3 in
> > > Grails 8.  Especially if we get the necessary support, but otherwise, we
> > > can continue with 2.x.
> > >
> > > Please note as part of this branch revert, I've also taken a closer look
> > at
> > > the Sitemesh licensing requirements and made a first pass being
> > compatible
> > > with the Sitemesh license.  We'll still have to follow-up with ASF legal
> > to
> > > ensure we're compliant since the license is a derivative of the ASF
> > > license.
> > >
> > > -James
> > >
> >
> 

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by James Daugherty <jd...@jdresources.net.INVALID>.
Thanks Scott for responding. We're not against Sitemesh 3, but we need your
help to fix these issues and we don't think we can get that done in a
timely manner.  Some of those tickets have been open for 8 months.

As for Sitemesh 2.6.0, if the intention is to never release it going
forward, we had discussed forking it into the grails project.  This will be
especially important if you think there won't be maintenance on it.

As for adopting Sitemesh 2.7.0, I noticed the buffer changes in 2.7.0 and
we would have to make it further compatible with 7 to adopt the latest
release.  If you can help us with these compatibility issues, we're happy
to adopt in the shorter term.

Our main issue is getting Grails 7 released though and the community
feedback we've received is there are too many issues to keep delaying
Grails 7.

-James

On Wed, Jul 2, 2025 at 1:26 PM Scott Murphy Heiberg <sc...@apache.org>
wrote:

> Sitemesh 3 was a complete rewrite that dramatically reduced the complexity
> of the rendering process.  It was also the introduction of the Apache 2
> license.  I would recommend just submitting a PR to Sitemesh 3 with
> whatever fixes are needed.
>
> Sitemesh 2.6.0 was never meant to be a replacement for anything and was
> just a quick patch for a codebase abandoned in 2009. It is a forked release
> with no future.
>
> If you were to revert to Sitemesh 2, the proper course would be to use
> Sitemesh 2.7.x
>
> On 2025/07/02 11:38:52 James Daugherty wrote:
> > Hi Everyone,
> >
> > I started investigating a ticket related to forwarding not working in a
> > Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> >
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> >  It seems the DispatcherServlet from Spring is designed to handle
> multiple
> > calls methods that cause the response to render and close.  The
> dispatcher
> > chooses  the right one by the committed state of the response.
> >
> > From my investigation, the Sitemesh 3 implementation appears to use a
> > filter to render its output after the DispatcherServlet is processed - so
> > the response state is never committed.  I think we could update the
> > GrailsDispatcherServlet to handle the various scenarios that the
> > DispatcherServlet handles, but I'm not sure this is practical for Grails
> 7
> > given the delays we have already had.  We would also be deviating from
> how
> > Spring MVC controllers are rendered and this logic doesn't appear that
> > simple.  Moreover, we still have several outstanding tickets related to
> the
> > sitemesh 3 upgrade:
> >
> > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > forwarding from a controller
> > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> > layouts
> > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw
> in
> > titles
> > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 -
> layout by
> > convention
> >
> > We have reached out to the developer of Sitemesh 3 on most of these
> tickets
> > (via ticket comments and direct slack messages over the past few months);
> > we have yet to receive any work or progress on them. The oldest of which
> is
> > 8+ months old. I'm skeptical these can be finished in a reasonable time
> > frame.
> >
> >
> > Given the lack of support, the multiple issues found by users, and the
> > current state of Grails 7 being delayed by these tickets, I would like to
> > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of
> these
> > issues are fixed, we would only have the remaining license, asset plugin
> > release, & ASF release related issues to fix before we could release
> Grails
> > 7.
> >
> >
> > I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> > branch (https://github.com/apache/grails-core/tree/issue14193).  As
> part of
> > switching back to v2, I discovered the following is now fixed:
> > * async rendering
> > * async error handling
> > * layout specified by a controller property
> > * layout specified in controller property applied to a GSP that does not
> > contain a root html tag
> >
> > It seems the sitemesh3 upgrade was performed during a time when the
> project
> > wasn't running all of its tests, so we are only now learning the scope of
> > its impact.  I think we can still be open to switching to Sitemesh 3 in
> > Grails 8.  Especially if we get the necessary support, but otherwise, we
> > can continue with 2.x.
> >
> > Please note as part of this branch revert, I've also taken a closer look
> at
> > the Sitemesh licensing requirements and made a first pass being
> compatible
> > with the Sitemesh license.  We'll still have to follow-up with ASF legal
> to
> > ensure we're compliant since the license is a derivative of the ASF
> > license.
> >
> > -James
> >
>

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by Scott Murphy Heiberg <sc...@apache.org>.
Sitemesh 3 was a complete rewrite that dramatically reduced the complexity of the rendering process.  It was also the introduction of the Apache 2 license.  I would recommend just submitting a PR to Sitemesh 3 with whatever fixes are needed.

Sitemesh 2.6.0 was never meant to be a replacement for anything and was just a quick patch for a codebase abandoned in 2009. It is a forked release with no future.  

If you were to revert to Sitemesh 2, the proper course would be to use Sitemesh 2.7.x

On 2025/07/02 11:38:52 James Daugherty wrote:
> Hi Everyone,
> 
> I started investigating a ticket related to forwarding not working in a
> Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
>  It seems the DispatcherServlet from Spring is designed to handle multiple
> calls methods that cause the response to render and close.  The dispatcher
> chooses  the right one by the committed state of the response.
> 
> From my investigation, the Sitemesh 3 implementation appears to use a
> filter to render its output after the DispatcherServlet is processed - so
> the response state is never committed.  I think we could update the
> GrailsDispatcherServlet to handle the various scenarios that the
> DispatcherServlet handles, but I'm not sure this is practical for Grails 7
> given the delays we have already had.  We would also be deviating from how
> Spring MVC controllers are rendered and this logic doesn't appear that
> simple.  Moreover, we still have several outstanding tickets related to the
> sitemesh 3 upgrade:
> 
> * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> forwarding from a controller
> * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> layouts
> * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw in
> titles
> * Nov 2024 - https://github.com/apache/grails-core/issues/13849 - layout by
> convention
> 
> We have reached out to the developer of Sitemesh 3 on most of these tickets
> (via ticket comments and direct slack messages over the past few months);
> we have yet to receive any work or progress on them. The oldest of which is
> 8+ months old. I'm skeptical these can be finished in a reasonable time
> frame.
> 
> 
> Given the lack of support, the multiple issues found by users, and the
> current state of Grails 7 being delayed by these tickets, I would like to
> propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of these
> issues are fixed, we would only have the remaining license, asset plugin
> release, & ASF release related issues to fix before we could release Grails
> 7.
> 
> 
> I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> branch (https://github.com/apache/grails-core/tree/issue14193).  As part of
> switching back to v2, I discovered the following is now fixed:
> * async rendering
> * async error handling
> * layout specified by a controller property
> * layout specified in controller property applied to a GSP that does not
> contain a root html tag
> 
> It seems the sitemesh3 upgrade was performed during a time when the project
> wasn't running all of its tests, so we are only now learning the scope of
> its impact.  I think we can still be open to switching to Sitemesh 3 in
> Grails 8.  Especially if we get the necessary support, but otherwise, we
> can continue with 2.x.
> 
> Please note as part of this branch revert, I've also taken a closer look at
> the Sitemesh licensing requirements and made a first pass being compatible
> with the Sitemesh license.  We'll still have to follow-up with ASF legal to
> ensure we're compliant since the license is a derivative of the ASF
> license.
> 
> -James
> 

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by James Daugherty <jd...@jdresources.net.INVALID>.
Based on the feedback in this week's meeting, I intend to go ahead and move
this straight to a vote thread.

On Wed, Jul 2, 2025 at 10:23 AM James Fredley <ja...@apache.org>
wrote:

> I believe this is the quickest and likely best way to ensure GSP in Grails
> 7 works the way it did in Grails 5 and 6.
>
> It addresses the long term open issues with Sitemesh 3 updates for Grails
> 7.  We can revisit Sitemesh 3 for Grails 8.
>
> It also fixes failing tests that we didn't know were caused by Sitemesh 3
> changes made before the majority of dependencies were updated for Grails 7
> in Summer and Fall 2024.
>
> James Fredley
>
> On 2025/07/02 11:38:52 James Daugherty wrote:
> > Hi Everyone,
> >
> > I started investigating a ticket related to forwarding not working in a
> > Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> >
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> >  It seems the DispatcherServlet from Spring is designed to handle
> multiple
> > calls methods that cause the response to render and close.  The
> dispatcher
> > chooses  the right one by the committed state of the response.
> >
> > From my investigation, the Sitemesh 3 implementation appears to use a
> > filter to render its output after the DispatcherServlet is processed - so
> > the response state is never committed.  I think we could update the
> > GrailsDispatcherServlet to handle the various scenarios that the
> > DispatcherServlet handles, but I'm not sure this is practical for Grails
> 7
> > given the delays we have already had.  We would also be deviating from
> how
> > Spring MVC controllers are rendered and this logic doesn't appear that
> > simple.  Moreover, we still have several outstanding tickets related to
> the
> > sitemesh 3 upgrade:
> >
> > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > forwarding from a controller
> > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> > layouts
> > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw
> in
> > titles
> > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 -
> layout by
> > convention
> >
> > We have reached out to the developer of Sitemesh 3 on most of these
> tickets
> > (via ticket comments and direct slack messages over the past few months);
> > we have yet to receive any work or progress on them. The oldest of which
> is
> > 8+ months old. I'm skeptical these can be finished in a reasonable time
> > frame.
> >
> >
> > Given the lack of support, the multiple issues found by users, and the
> > current state of Grails 7 being delayed by these tickets, I would like to
> > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of
> these
> > issues are fixed, we would only have the remaining license, asset plugin
> > release, & ASF release related issues to fix before we could release
> Grails
> > 7.
> >
> >
> > I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> > branch (https://github.com/apache/grails-core/tree/issue14193).  As
> part of
> > switching back to v2, I discovered the following is now fixed:
> > * async rendering
> > * async error handling
> > * layout specified by a controller property
> > * layout specified in controller property applied to a GSP that does not
> > contain a root html tag
> >
> > It seems the sitemesh3 upgrade was performed during a time when the
> project
> > wasn't running all of its tests, so we are only now learning the scope of
> > its impact.  I think we can still be open to switching to Sitemesh 3 in
> > Grails 8.  Especially if we get the necessary support, but otherwise, we
> > can continue with 2.x.
> >
> > Please note as part of this branch revert, I've also taken a closer look
> at
> > the Sitemesh licensing requirements and made a first pass being
> compatible
> > with the Sitemesh license.  We'll still have to follow-up with ASF legal
> to
> > ensure we're compliant since the license is a derivative of the ASF
> > license.
> >
> > -James
> >
>

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by Andrew Garcia <an...@goodshuffle.com.INVALID>.
agreed

On Wed, Jul 2, 2025 at 11:57 AM Mattias Reichel <ma...@gmail.com>
wrote:

> Yes, I think it's the right thing to do at this point.
>
> /Mattias
>
> Den ons 2 juli 2025 kl 16:23 skrev James Fredley <jamesfredley@apache.org
> >:
>
> > I believe this is the quickest and likely best way to ensure GSP in
> Grails
> > 7 works the way it did in Grails 5 and 6.
> >
> > It addresses the long term open issues with Sitemesh 3 updates for Grails
> > 7.  We can revisit Sitemesh 3 for Grails 8.
> >
> > It also fixes failing tests that we didn't know were caused by Sitemesh 3
> > changes made before the majority of dependencies were updated for Grails
> 7
> > in Summer and Fall 2024.
> >
> > James Fredley
> >
> > On 2025/07/02 11:38:52 James Daugherty wrote:
> > > Hi Everyone,
> > >
> > > I started investigating a ticket related to forwarding not working in a
> > > Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> > >
> >
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> > >  It seems the DispatcherServlet from Spring is designed to handle
> > multiple
> > > calls methods that cause the response to render and close.  The
> > dispatcher
> > > chooses  the right one by the committed state of the response.
> > >
> > > From my investigation, the Sitemesh 3 implementation appears to use a
> > > filter to render its output after the DispatcherServlet is processed -
> so
> > > the response state is never committed.  I think we could update the
> > > GrailsDispatcherServlet to handle the various scenarios that the
> > > DispatcherServlet handles, but I'm not sure this is practical for
> Grails
> > 7
> > > given the delays we have already had.  We would also be deviating from
> > how
> > > Spring MVC controllers are rendered and this logic doesn't appear that
> > > simple.  Moreover, we still have several outstanding tickets related to
> > the
> > > sitemesh 3 upgrade:
> > >
> > > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > > forwarding from a controller
> > > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 -
> nested
> > > layouts
> > > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw
> > in
> > > titles
> > > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 -
> > layout by
> > > convention
> > >
> > > We have reached out to the developer of Sitemesh 3 on most of these
> > tickets
> > > (via ticket comments and direct slack messages over the past few
> months);
> > > we have yet to receive any work or progress on them. The oldest of
> which
> > is
> > > 8+ months old. I'm skeptical these can be finished in a reasonable time
> > > frame.
> > >
> > >
> > > Given the lack of support, the multiple issues found by users, and the
> > > current state of Grails 7 being delayed by these tickets, I would like
> to
> > > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of
> > these
> > > issues are fixed, we would only have the remaining license, asset
> plugin
> > > release, & ASF release related issues to fix before we could release
> > Grails
> > > 7.
> > >
> > >
> > > I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> > > branch (https://github.com/apache/grails-core/tree/issue14193).  As
> > part of
> > > switching back to v2, I discovered the following is now fixed:
> > > * async rendering
> > > * async error handling
> > > * layout specified by a controller property
> > > * layout specified in controller property applied to a GSP that does
> not
> > > contain a root html tag
> > >
> > > It seems the sitemesh3 upgrade was performed during a time when the
> > project
> > > wasn't running all of its tests, so we are only now learning the scope
> of
> > > its impact.  I think we can still be open to switching to Sitemesh 3 in
> > > Grails 8.  Especially if we get the necessary support, but otherwise,
> we
> > > can continue with 2.x.
> > >
> > > Please note as part of this branch revert, I've also taken a closer
> look
> > at
> > > the Sitemesh licensing requirements and made a first pass being
> > compatible
> > > with the Sitemesh license.  We'll still have to follow-up with ASF
> legal
> > to
> > > ensure we're compliant since the license is a derivative of the ASF
> > > license.
> > >
> > > -James
> > >
> >
>


-- 

*Andrew Garcia* | Co-Founder & CEO
andrew@goodshuffle.com

*Goodshuffle Pro*
<https://pro.goodshuffle.com/?utm_source=goodshuffle&utm_medium=email&utm_campaign=employeesignature&fbid=emailsignaturehomepage>
 | Read our reviews on Capterra
<https://www.capterra.com/p/167364/Goodshuffle-Pro/reviews/>

<https://www.facebook.com/Goodshuffle/>
<https://www.instagram.com/goodshuffle/>
<https://www.linkedin.com/company/goodshuffle/posts/?feedView=all>
<https://www.youtube.com/c/GoodshufflePro>

<https://pro.goodshuffle.com/dispatch-lp?utm_source=goodshuffle&utm_medium=referral&utm_campaign=Feature_Release>

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by Mattias Reichel <ma...@gmail.com>.
Yes, I think it's the right thing to do at this point.

/Mattias

Den ons 2 juli 2025 kl 16:23 skrev James Fredley <ja...@apache.org>:

> I believe this is the quickest and likely best way to ensure GSP in Grails
> 7 works the way it did in Grails 5 and 6.
>
> It addresses the long term open issues with Sitemesh 3 updates for Grails
> 7.  We can revisit Sitemesh 3 for Grails 8.
>
> It also fixes failing tests that we didn't know were caused by Sitemesh 3
> changes made before the majority of dependencies were updated for Grails 7
> in Summer and Fall 2024.
>
> James Fredley
>
> On 2025/07/02 11:38:52 James Daugherty wrote:
> > Hi Everyone,
> >
> > I started investigating a ticket related to forwarding not working in a
> > Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> >
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
> >  It seems the DispatcherServlet from Spring is designed to handle
> multiple
> > calls methods that cause the response to render and close.  The
> dispatcher
> > chooses  the right one by the committed state of the response.
> >
> > From my investigation, the Sitemesh 3 implementation appears to use a
> > filter to render its output after the DispatcherServlet is processed - so
> > the response state is never committed.  I think we could update the
> > GrailsDispatcherServlet to handle the various scenarios that the
> > DispatcherServlet handles, but I'm not sure this is practical for Grails
> 7
> > given the delays we have already had.  We would also be deviating from
> how
> > Spring MVC controllers are rendered and this logic doesn't appear that
> > simple.  Moreover, we still have several outstanding tickets related to
> the
> > sitemesh 3 upgrade:
> >
> > * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> > forwarding from a controller
> > * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> > layouts
> > * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw
> in
> > titles
> > * Nov 2024 - https://github.com/apache/grails-core/issues/13849 -
> layout by
> > convention
> >
> > We have reached out to the developer of Sitemesh 3 on most of these
> tickets
> > (via ticket comments and direct slack messages over the past few months);
> > we have yet to receive any work or progress on them. The oldest of which
> is
> > 8+ months old. I'm skeptical these can be finished in a reasonable time
> > frame.
> >
> >
> > Given the lack of support, the multiple issues found by users, and the
> > current state of Grails 7 being delayed by these tickets, I would like to
> > propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of
> these
> > issues are fixed, we would only have the remaining license, asset plugin
> > release, & ASF release related issues to fix before we could release
> Grails
> > 7.
> >
> >
> > I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> > branch (https://github.com/apache/grails-core/tree/issue14193).  As
> part of
> > switching back to v2, I discovered the following is now fixed:
> > * async rendering
> > * async error handling
> > * layout specified by a controller property
> > * layout specified in controller property applied to a GSP that does not
> > contain a root html tag
> >
> > It seems the sitemesh3 upgrade was performed during a time when the
> project
> > wasn't running all of its tests, so we are only now learning the scope of
> > its impact.  I think we can still be open to switching to Sitemesh 3 in
> > Grails 8.  Especially if we get the necessary support, but otherwise, we
> > can continue with 2.x.
> >
> > Please note as part of this branch revert, I've also taken a closer look
> at
> > the Sitemesh licensing requirements and made a first pass being
> compatible
> > with the Sitemesh license.  We'll still have to follow-up with ASF legal
> to
> > ensure we're compliant since the license is a derivative of the ASF
> > license.
> >
> > -James
> >
>

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by James Fredley <ja...@apache.org>.
I believe this is the quickest and likely best way to ensure GSP in Grails 7 works the way it did in Grails 5 and 6.

It addresses the long term open issues with Sitemesh 3 updates for Grails 7.  We can revisit Sitemesh 3 for Grails 8.

It also fixes failing tests that we didn't know were caused by Sitemesh 3 changes made before the majority of dependencies were updated for Grails 7 in Summer and Fall 2024.  

James Fredley

On 2025/07/02 11:38:52 James Daugherty wrote:
> Hi Everyone,
> 
> I started investigating a ticket related to forwarding not working in a
> Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
>  It seems the DispatcherServlet from Spring is designed to handle multiple
> calls methods that cause the response to render and close.  The dispatcher
> chooses  the right one by the committed state of the response.
> 
> From my investigation, the Sitemesh 3 implementation appears to use a
> filter to render its output after the DispatcherServlet is processed - so
> the response state is never committed.  I think we could update the
> GrailsDispatcherServlet to handle the various scenarios that the
> DispatcherServlet handles, but I'm not sure this is practical for Grails 7
> given the delays we have already had.  We would also be deviating from how
> Spring MVC controllers are rendered and this logic doesn't appear that
> simple.  Moreover, we still have several outstanding tickets related to the
> sitemesh 3 upgrade:
> 
> * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> forwarding from a controller
> * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> layouts
> * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw in
> titles
> * Nov 2024 - https://github.com/apache/grails-core/issues/13849 - layout by
> convention
> 
> We have reached out to the developer of Sitemesh 3 on most of these tickets
> (via ticket comments and direct slack messages over the past few months);
> we have yet to receive any work or progress on them. The oldest of which is
> 8+ months old. I'm skeptical these can be finished in a reasonable time
> frame.
> 
> 
> Given the lack of support, the multiple issues found by users, and the
> current state of Grails 7 being delayed by these tickets, I would like to
> propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of these
> issues are fixed, we would only have the remaining license, asset plugin
> release, & ASF release related issues to fix before we could release Grails
> 7.
> 
> 
> I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> branch (https://github.com/apache/grails-core/tree/issue14193).  As part of
> switching back to v2, I discovered the following is now fixed:
> * async rendering
> * async error handling
> * layout specified by a controller property
> * layout specified in controller property applied to a GSP that does not
> contain a root html tag
> 
> It seems the sitemesh3 upgrade was performed during a time when the project
> wasn't running all of its tests, so we are only now learning the scope of
> its impact.  I think we can still be open to switching to Sitemesh 3 in
> Grails 8.  Especially if we get the necessary support, but otherwise, we
> can continue with 2.x.
> 
> Please note as part of this branch revert, I've also taken a closer look at
> the Sitemesh licensing requirements and made a first pass being compatible
> with the Sitemesh license.  We'll still have to follow-up with ASF legal to
> ensure we're compliant since the license is a derivative of the ASF
> license.
> 
> -James
> 

Re: [DISCUSS] - Grails 7 & Reverting Sitemesh 3

Posted by Søren Berg Glasius <so...@glasius.dk>.
Hi list,

I agree that we need to move forward, even if that means having to revert
to Sitemesh 2.6.0. Getting Grails 7 to GA is IMO way more important than to
have a more modernized GSP engine.

Also agree that Sitemesh3 could be a target for Grails 8.

Good work James D!!

Den ons. 2. jul. 2025 kl. 13.39 skrev James Daugherty <jdaugherty@apache.org
>:

> Hi Everyone,
>
> I started investigating a ticket related to forwarding not working in a
> Grails controller on 7.0.0-M4.  As part of that I made this discovery:
> https://github.com/apache/grails-core/issues/14193#issuecomment-3017157073
>  It seems the DispatcherServlet from Spring is designed to handle multiple
> calls methods that cause the response to render and close.  The dispatcher
> chooses  the right one by the committed state of the response.
>
> From my investigation, the Sitemesh 3 implementation appears to use a
> filter to render its output after the DispatcherServlet is processed - so
> the response state is never committed.  I think we could update the
> GrailsDispatcherServlet to handle the various scenarios that the
> DispatcherServlet handles, but I'm not sure this is practical for Grails 7
> given the delays we have already had.  We would also be deviating from how
> Spring MVC controllers are rendered and this logic doesn't appear that
> simple.  Moreover, we still have several outstanding tickets related to the
> sitemesh 3 upgrade:
>
> * Apr 2025 - https://github.com/apache/grails-core/issues/14193 -
> forwarding from a controller
> * Jan 2025 - https://github.com/apache/grails-core/issues/13988 - nested
> layouts
> * Feb 2005 - https://github.com/apache/grails-core/issues/14197 - $raw in
> titles
> * Nov 2024 - https://github.com/apache/grails-core/issues/13849 - layout
> by
> convention
>
> We have reached out to the developer of Sitemesh 3 on most of these tickets
> (via ticket comments and direct slack messages over the past few months);
> we have yet to receive any work or progress on them. The oldest of which is
> 8+ months old. I'm skeptical these can be finished in a reasonable time
> frame.
>
>
> Given the lack of support, the multiple issues found by users, and the
> current state of Grails 7 being delayed by these tickets, I would like to
> propose we revert back to Sitemesh 2.6.0.  Assuming we confirm all of these
> issues are fixed, we would only have the remaining license, asset plugin
> release, & ASF release related issues to fix before we could release Grails
> 7.
>
>
> I have gone ahead and reverted back to Sitemesh 2.6.0 in the issue14193
> branch (https://github.com/apache/grails-core/tree/issue14193).  As part
> of
> switching back to v2, I discovered the following is now fixed:
> * async rendering
> * async error handling
> * layout specified by a controller property
> * layout specified in controller property applied to a GSP that does not
> contain a root html tag
>
> It seems the sitemesh3 upgrade was performed during a time when the project
> wasn't running all of its tests, so we are only now learning the scope of
> its impact.  I think we can still be open to switching to Sitemesh 3 in
> Grails 8.  Especially if we get the necessary support, but otherwise, we
> can continue with 2.x.
>
> Please note as part of this branch revert, I've also taken a closer look at
> the Sitemesh licensing requirements and made a first pass being compatible
> with the Sitemesh license.  We'll still have to follow-up with ASF legal to
> ensure we're compliant since the license is a derivative of the ASF
> license.
>
> -James
>


-- 

Med venlig hilsen,
Søren Berg Glasius

Hedevej 1, Gl. Rye, 8680 Ry
Mobile: +45 40 44 91 88
--- Press ESC once to quit - twice to save the changes.