You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/30 05:38:11 UTC
[GitHub] [pinot] KKcorps opened a new issue #8437: Support multiple response formats in Broker SQL API
KKcorps opened a new issue #8437:
URL: https://github.com/apache/pinot/issues/8437
Currently, for a query, broker can only return JSON response. However, for better performance on client side, it might be desirable to get response in a compact, fast, binary format such as Avro, ProtoBuf, FlatBuffers etc.
There are two changes that can be done to support this request -
* Create a gRPC client for existing gRPC broker service and provide it to users.
* Allow a `format` parameter to be passed in `/query` API and return response in the specified format.
```
curl --location --request POST 'http://localhost:8000/query/sql' \
--header 'Content-Type: application/json' \
--data-raw '{"sql" : "SELECT * FROM baseballStats LIMIT 10",
"format" : "avro"
}'
```
This will reduce the deserialization cost on the client end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] KKcorps commented on issue #8437: Support multiple response formats in Broker SQL API
Posted by GitBox <gi...@apache.org>.
KKcorps commented on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1082646626
It will look something like this - https://github.com/KKcorps/incubator-pinot/pull/1/files
I do not like adding `avro` dependency to broker though so might move the classes to some other module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #8437: Support multiple response formats in Broker SQL API
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1084853463
The idea is really good. Suggest making the `ResponseWriter` pluggable, and we provide some default impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] KKcorps edited a comment on issue #8437: Support multiple response formats in Broker SQL API
Posted by GitBox <gi...@apache.org>.
KKcorps edited a comment on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1082646626
It will look something like this - https://github.com/KKcorps/incubator-pinot/pull/1/files
This is a very crude implementation and final PR should look really different from this.
Things I do not like -
* Adding format dependencies to broker
* Relying on reflections
* Missing utility to generate avro/proto schema file for `BrokerResponseNative`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] KKcorps commented on issue #8437: Support multiple response formats in Broker SQL API
Posted by GitBox <gi...@apache.org>.
KKcorps commented on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1082642019
@Jackie-Jiang @mayankshriv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org