You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/07 18:03:00 UTC

[GitHub] [incubator-superset] codecov-io commented on pull request #9765: chore: remove unnecessary shims from viz.py

codecov-io commented on pull request #9765:
URL: https://github.com/apache/incubator-superset/pull/9765#issuecomment-625410458


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9765?src=pr&el=h1) Report
   > Merging [#9765](https://codecov.io/gh/apache/incubator-superset/pull/9765?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5b430ead42c38692183a5471bf0b4bb4cb48eb20&el=desc) will **decrease** coverage by `0.19%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9765/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9765?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9765      +/-   ##
   ==========================================
   - Coverage   70.81%   70.61%   -0.20%     
   ==========================================
     Files         586      403     -183     
     Lines       30445    12598   -17847     
     Branches     3121     3121              
   ==========================================
   - Hits        21559     8896   -12663     
   + Misses       8772     3588    -5184     
     Partials      114      114              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.65% <ø> (-0.08%)` | :arrow_down: |
   | #javascript | `59.06% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9765?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (ø)` | |
   | [...migrations/versions/fb13d49b72f9\_better\_filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9mYjEzZDQ5YjcyZjlfYmV0dGVyX2ZpbHRlcnMucHk=) | | |
   | [superset/extensions.py](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXh0ZW5zaW9ucy5weQ==) | | |
   | [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | | |
   | [superset/queries/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zY2hlbWFzLnB5) | | |
   | [superset/examples/paris.py](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | | |
   | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | | |
   | [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | | |
   | [superset/views/dashboard/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | | |
   | ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/9765/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9765?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9765?src=pr&el=footer). Last update [5b430ea...b47b78c](https://codecov.io/gh/apache/incubator-superset/pull/9765?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org