You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/01 12:05:00 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #1898: Remove uneeded Mutex in Ballista Client
alamb opened a new pull request #1898:
URL: https://github.com/apache/arrow-datafusion/pull/1898
Builds on https://github.com/apache/arrow-datafusion/pull/1884, so draft until that is merged
# Which issue does this PR close?
re: https://github.com/apache/arrow-datafusion/issues/1614
# Rationale for this change
I added a somewhat nasty `Mutex` workaround in https://github.com/apache/arrow-datafusion/pull/1523 due to some changes in how prost / tonic. Now that @doki has updated the `SendableRecordBatchStream` in #1884 this workaround can be removed
I don't think removing this `Mutex` has any practical performance implications, but it makes the code cleaner
# What changes are included in this PR?
* Removes mutex added in https://github.com/apache/arrow-datafusion/pull/1523
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1898: Remove uneeded Mutex in Ballista Client
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1898:
URL: https://github.com/apache/arrow-datafusion/pull/1898#issuecomment-1059950768
cc @tustvold who pointed out this mess initially
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1898: Remove uneeded Mutex in Ballista Client
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1898:
URL: https://github.com/apache/arrow-datafusion/pull/1898#issuecomment-1059950828
And thanks again to @doki23 for unlocking this cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #1898: Remove uneeded Mutex in Ballista Client
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1898:
URL: https://github.com/apache/arrow-datafusion/pull/1898#issuecomment-1059770069
Rebased
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1898: Remove uneeded Mutex in Ballista Client
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1898:
URL: https://github.com/apache/arrow-datafusion/pull/1898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org