You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by km...@apache.org on 2008/05/21 01:28:39 UTC

svn commit: r658488 - in /tapestry/tapestry5/trunk: tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/ tapestry-ioc/src/site/apt/cookbook/

Author: kmenard
Date: Tue May 20 16:28:39 2008
New Revision: 658488

URL: http://svn.apache.org/viewvc?rev=658488&view=rev
Log:
Use SymbolConstants throughout.

Modified:
    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java
    tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java
    tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt

Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java?rev=658488&r1=658487&r2=658488&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java Tue May 20 16:28:39 2008
@@ -19,6 +19,7 @@
 import org.apache.tapestry5.ioc.internal.util.CollectionFactory;
 import org.apache.tapestry5.ioc.services.ThreadLocale;
 import org.apache.tapestry5.services.PersistentLocale;
+import org.apache.tapestry5.SymbolConstants;
 
 import java.util.Locale;
 import java.util.Map;
@@ -42,7 +43,7 @@
 
     public LocalizationSetterImpl(PersistentLocale persistentLocale, ThreadLocale threadLocale,
                                   @Inject
-                                  @Symbol("tapestry.supported-locales")
+                                  @Symbol(SymbolConstants.SUPPORTED_LOCALES)
                                   String acceptedLocaleNames)
     {
         this.persistentLocale = persistentLocale;

Modified: tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java?rev=658488&r1=658487&r2=658488&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java Tue May 20 16:28:39 2008
@@ -22,12 +22,13 @@
 import org.apache.tapestry5.services.ClassTransformation;
 import org.apache.tapestry5.services.ComponentClassTransformWorker;
 import org.apache.tapestry5.services.TransformMethodSignature;
+import org.apache.tapestry5.SymbolConstants;
 
 public class LocaleAppModule
 {
     public static void contributeApplicationDefaults(MappedConfiguration<String, String> configuration)
     {
-        configuration.add("tapestry.supported-locales", "en,fr,de");
+        configuration.add(SymbolConstants.SUPPORTED_LOCALES, "en,fr,de");
     }
 
     public static void contributeComponentClassTransformWorker(

Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt?rev=658488&r1=658487&r2=658488&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt (original)
+++ tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt Tue May 20 16:28:39 2008
@@ -178,9 +178,9 @@
 +----+
   public static void contributeFactoryDefaults(MappedConfiguration<String, String> configuration)
   {
-    configuration.add("tapestry.file-check-interval", "1000"); // 1 second
-    configuration.add("tapestry.file-check-update-timeout", "50"); // 50 milliseconds
-    configuration.add("tapestry.supported-locales", "en");
+    configuration.add(SymbolConstants.FILE_CHECK_INTERVAL, "1000"); // 1 second
+    configuration.add(SymbolConstants.FILE_CHECK_UPDATE_TIMEOUT, "50"); // 50 milliseconds
+    configuration.add(SymbolConstants.SUPPORTED_LOCALES, "en");
     configuration.add("tapestry.default-cookie-max-age", "604800"); // One week
     configuration.add("tapestry.start-page-name", "start");
     configuration.add("tapestry.scriptaculous", "classpath:${tapestry.scriptaculous.path}");



Re: svn commit: r658488 - in /tapestry/tapestry5/trunk: tapestry-core/src/main/java/org/apache/tapestry5/internal/services/ tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/ tapestry-ioc/src/site/apt/cookbook/

Posted by Howard Lewis Ship <hl...@gmail.com>.
Thanks!

On Tue, May 20, 2008 at 4:28 PM,  <km...@apache.org> wrote:
> Author: kmenard
> Date: Tue May 20 16:28:39 2008
> New Revision: 658488
>
> URL: http://svn.apache.org/viewvc?rev=658488&view=rev
> Log:
> Use SymbolConstants throughout.
>
> Modified:
>    tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java
>    tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java
>    tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt
>
> Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java?rev=658488&r1=658487&r2=658488&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java (original)
> +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/LocalizationSetterImpl.java Tue May 20 16:28:39 2008
> @@ -19,6 +19,7 @@
>  import org.apache.tapestry5.ioc.internal.util.CollectionFactory;
>  import org.apache.tapestry5.ioc.services.ThreadLocale;
>  import org.apache.tapestry5.services.PersistentLocale;
> +import org.apache.tapestry5.SymbolConstants;
>
>  import java.util.Locale;
>  import java.util.Map;
> @@ -42,7 +43,7 @@
>
>     public LocalizationSetterImpl(PersistentLocale persistentLocale, ThreadLocale threadLocale,
>                                   @Inject
> -                                  @Symbol("tapestry.supported-locales")
> +                                  @Symbol(SymbolConstants.SUPPORTED_LOCALES)
>                                   String acceptedLocaleNames)
>     {
>         this.persistentLocale = persistentLocale;
>
> Modified: tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java?rev=658488&r1=658487&r2=658488&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java (original)
> +++ tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app2/services/LocaleAppModule.java Tue May 20 16:28:39 2008
> @@ -22,12 +22,13 @@
>  import org.apache.tapestry5.services.ClassTransformation;
>  import org.apache.tapestry5.services.ComponentClassTransformWorker;
>  import org.apache.tapestry5.services.TransformMethodSignature;
> +import org.apache.tapestry5.SymbolConstants;
>
>  public class LocaleAppModule
>  {
>     public static void contributeApplicationDefaults(MappedConfiguration<String, String> configuration)
>     {
> -        configuration.add("tapestry.supported-locales", "en,fr,de");
> +        configuration.add(SymbolConstants.SUPPORTED_LOCALES, "en,fr,de");
>     }
>
>     public static void contributeComponentClassTransformWorker(
>
> Modified: tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt
> URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt?rev=658488&r1=658487&r2=658488&view=diff
> ==============================================================================
> --- tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt (original)
> +++ tapestry/tapestry5/trunk/tapestry-ioc/src/site/apt/cookbook/servconf.apt Tue May 20 16:28:39 2008
> @@ -178,9 +178,9 @@
>  +----+
>   public static void contributeFactoryDefaults(MappedConfiguration<String, String> configuration)
>   {
> -    configuration.add("tapestry.file-check-interval", "1000"); // 1 second
> -    configuration.add("tapestry.file-check-update-timeout", "50"); // 50 milliseconds
> -    configuration.add("tapestry.supported-locales", "en");
> +    configuration.add(SymbolConstants.FILE_CHECK_INTERVAL, "1000"); // 1 second
> +    configuration.add(SymbolConstants.FILE_CHECK_UPDATE_TIMEOUT, "50"); // 50 milliseconds
> +    configuration.add(SymbolConstants.SUPPORTED_LOCALES, "en");
>     configuration.add("tapestry.default-cookie-max-age", "604800"); // One week
>     configuration.add("tapestry.start-page-name", "start");
>     configuration.add("tapestry.scriptaculous", "classpath:${tapestry.scriptaculous.path}");
>
>
>



-- 
Howard M. Lewis Ship

Creator Apache Tapestry and Apache HiveMind

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org