You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Jon Haddad (JIRA)" <ji...@apache.org> on 2017/03/06 05:09:32 UTC

[jira] [Commented] (CASSANDRA-13271) Reduce lock contention for collection types and serializers

    [ https://issues.apache.org/jira/browse/CASSANDRA-13271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896750#comment-15896750 ] 

Jon Haddad commented on CASSANDRA-13271:
----------------------------------------

Am I missing something here?  Did we really just commit an optimization without any benchmarks? 

> Reduce lock contention for collection types and serializers
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-13271
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13271
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: vincent royer
>            Priority: Minor
>              Labels: performance
>             Fix For: 4.0
>
>         Attachments: 0001-CASSANDRA-13271-computeIfAbsent.patch, 0001-CASSANDRA-13271-singleton-factory-concurrency-opimiz.patch
>
>
> By doing some performance tests, i noticed that getInstance() in org.apache.cassandra.db.marshal.ListType and SetType could suffer from lock contention on the singleton factory getInstance(). Here is a proposal to reduce lock contention by using a ConcurrentMap and the putIfAbsent method rather than a synchronized method.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)