[GitHub] [airflow] ashb opened a new pull request #5039: [AIRFLOW-4240] Require POST for state-changing requests

[GitBox <gi...@apache.org>]

ashb opened a new pull request #5039: [AIRFLOW-4240] Require POST for state-changing requests
URL: https://github.com/apache/airflow/pull/5039
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] https://issues.apache.org/jira/browse/AIRFLOW-4240
   
   ### Description
   
   - [x] To make the requests POSTs and to follow the redirect that the backend
   issue I turned the "toggle" buttons in to an actual form, which makes
   there much less logic needed to build up the URL - the browser handles
   it all for us. The only thing we have to do is set the "action" on the
   URL.
   
     For the "link" ones (delete,trigger,refresh) I wrote a short
   `postAsForm` which takes the URL and submits a form. A little bit messy,
   but it works.
   
     No visual change.
   ### Tests
   
   - [x] Updated
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services