You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "Startrekzky (via GitHub)" <gi...@apache.org> on 2023/08/16 04:45:57 UTC
[GitHub] [incubator-devlake-website] Startrekzky opened a new pull request, #624: fix: optimize the images in google search results
Startrekzky opened a new pull request, #624:
URL: https://github.com/apache/incubator-devlake-website/pull/624
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [x] I have `npm run build` and `npm run serve` locally before submitting this PR
- [ ] I have read through the [Contributing](https://devlake.apache.org/community/) Documentation
# Summary
1. update the logo
2. update the trademark
3. update the alt for images
<!--
Thanks for submitting a PR! We appreciate you spending the time to work on these changes. Please fill out as many sections below as possible.
-->
### Does this close any open issues?
N/A
### Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] mintsweet commented on a diff in pull request #624: fix: optimize the images in google search results
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #624:
URL: https://github.com/apache/incubator-devlake-website/pull/624#discussion_r1295566432
##########
docusaurus.config.js:
##########
@@ -146,7 +146,7 @@ const versions = require('./versions.json');
navbar: {
title: 'Apache DevLake',
logo: {
- alt: 'apache-devlake',
+ alt: 'logo',
Review Comment:
Get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] mintsweet commented on a diff in pull request #624: fix: optimize the images in google search results
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet commented on code in PR #624:
URL: https://github.com/apache/incubator-devlake-website/pull/624#discussion_r1295393399
##########
docusaurus.config.js:
##########
@@ -146,7 +146,7 @@ const versions = require('./versions.json');
navbar: {
title: 'Apache DevLake',
logo: {
- alt: 'apache-devlake',
+ alt: 'logo',
Review Comment:
why can you not use `devlake` as a keyword?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] mintsweet merged pull request #624: fix: optimize the images in google search results
Posted by "mintsweet (via GitHub)" <gi...@apache.org>.
mintsweet merged PR #624:
URL: https://github.com/apache/incubator-devlake-website/pull/624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] Startrekzky commented on a diff in pull request #624: fix: optimize the images in google search results
Posted by "Startrekzky (via GitHub)" <gi...@apache.org>.
Startrekzky commented on code in PR #624:
URL: https://github.com/apache/incubator-devlake-website/pull/624#discussion_r1295563507
##########
docusaurus.config.js:
##########
@@ -146,7 +146,7 @@ const versions = require('./versions.json');
navbar: {
title: 'Apache DevLake',
logo: {
- alt: 'apache-devlake',
+ alt: 'logo',
Review Comment:
@mintsweet Because I want to show the other image. So I removed `devlake` from the logo's alt and added the `devlake` to the DORA image's alt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org