[jira] [Commented] (HTRACE-17) pom.xml cleanups

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243886#comment-14243886 ] 

stack commented on HTRACE-17:
-----------------------------

LGTM +1.

On commit remove this from your patch since version is specified in the top-level pom.

      <version>1.1.1</version>

We are java 1.6.  Maybe make a minimum of 1.7 in another JIRA?

> pom.xml cleanups
> ----------------
>
>                 Key: HTRACE-17
>                 URL: https://issues.apache.org/jira/browse/HTRACE-17
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-17.001.patch
>
>
> pom.xml cleanups
> * fix urls in pom.xml to point to new git repo and project page
> * set {{failIfNoTests}} to {{false}}, so that it is possible to run {{mvn test -Dtest=TestSampler}} and so forth from the top level without getting "error: no tests were run" on one of the subprojects.
> * don't run go tests when {{\-DskipTests}} was specified
> * shade commons-logging in htrace-core (so that we don't conflict with whatever version Hadoop or other software wants to use)
> * remove old references to shading guava in the pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)