You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/16 04:55:14 UTC
[GitHub] [pinot] kautshukla opened a new issue #7773: JDBC client : Headers should be passed in PinotControllerTransport while creating instance of PinotConnetion
kautshukla opened a new issue #7773:
URL: https://github.com/apache/pinot/issues/7773
https://github.com/apache/pinot/blob/d1606cd0f3877c1a8ec08255d003ef104a94c500/pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotDriver.java#L71
Prerequisite: https://github.com/apache/pinot/blob/d1606cd0f3877c1a8ec08255d003ef104a94c500/pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotDriver.java#L60 : headers map is not empty {JDBC with headers for Auth enabled client}
As of now:
return new PinotConnection(controllerUrl, pinotClientTransport, tenant);
It should be:
if(!headers.isEmpty)
return new PinotConnection(controllerUrl, pinotClientTransport, tenant, new PinotControllerTransport(headers));
return new PinotConnection(controllerUrl, pinotClientTransport, tenant);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang closed issue #7773: JDBC client : Headers should be passed in PinotControllerTransport while creating instance of PinotConnetion
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang closed issue #7773:
URL: https://github.com/apache/pinot/issues/7773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kautshukla commented on issue #7773: JDBC client : Headers should be passed in PinotControllerTransport while creating instance of PinotConnetion
Posted by GitBox <gi...@apache.org>.
kautshukla commented on issue #7773:
URL: https://github.com/apache/pinot/issues/7773#issuecomment-974759551
>
@xiangfu0 : Already raised it.
https://github.com/apache/pinot/pull/7774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kbastani commented on issue #7773: JDBC client : Headers should be passed in PinotControllerTransport while creating instance of PinotConnetion
Posted by GitBox <gi...@apache.org>.
kbastani commented on issue #7773:
URL: https://github.com/apache/pinot/issues/7773#issuecomment-971744644
@xiangfu0 Can we merge before 0.9.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #7773: JDBC client : Headers should be passed in PinotControllerTransport while creating instance of PinotConnetion
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #7773:
URL: https://github.com/apache/pinot/issues/7773#issuecomment-971892578
0.9.0 is already cut and about to release, we may include this in 0.10.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #7773: JDBC client : Headers should be passed in PinotControllerTransport while creating instance of PinotConnetion
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #7773:
URL: https://github.com/apache/pinot/issues/7773#issuecomment-971893502
@kautshukla Please file a PR for the change :)
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kautshukla commented on issue #7773: JDBC client : Headers should be passed in PinotControllerTransport while creating instance of PinotConnetion
Posted by GitBox <gi...@apache.org>.
kautshukla commented on issue #7773:
URL: https://github.com/apache/pinot/issues/7773#issuecomment-974759551
>
@xiangfu0 : Already raised it.
https://github.com/apache/pinot/pull/7774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org