[GitHub] [flink] lincoln-lil commented on a change in pull request #17792: [FLINK-24763][fs-connector] LimitableReader should swallow exception when reached limit

[GitBox <gi...@apache.org>]

lincoln-lil commented on a change in pull request #17792:
URL: https://github.com/apache/flink/pull/17792#discussion_r749034827



##########
File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/LimitableBulkFormat.java
##########
@@ -105,8 +111,16 @@ private boolean reachLimit() {
                 return null;
             }
 
-            RecordIterator<T> batch = reader.readBatch();
-            return batch == null ? null : new LimitableIterator(batch);
+            try {
+                RecordIterator<T> batch = reader.readBatch();
+                return batch == null ? null : new LimitableIterator(batch);
+            } catch (Exception e) {

Review comment:
       nit: the java.lang.IllegalStateException(reported in the issue) is a RuntimeException, not an IOException, so it doesn't match the method signature.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org