You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/23 14:32:51 UTC
[GitHub] [solr] risdenk opened a new pull request #693: SOLR-16048: Examine Tika dependencies that brought in javax classes
risdenk opened a new pull request #693:
URL: https://github.com/apache/solr/pull/693
https://issues.apache.org/jira/browse/SOLR-16048
* jakarta.annotation-api should not be needed so excluded from
tika-parsers
* jakarta.activation - this should be allowed so exclusion in smokeTestRelease
* jakarta.xml.bind-api - this should be allowed so exclusion in smokeTestRelease
* unit-api - this should be allowed so exclusion in smokeTestRelease
* removed jersey and xml-api exclusion since they aren't dependencies
anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #693: SOLR-16048: Examine Tika dependencies that brought in javax classes
Posted by GitBox <gi...@apache.org>.
risdenk commented on pull request #693:
URL: https://github.com/apache/solr/pull/693#issuecomment-1048873549
@janhoy so I went to remove `jakarta.annotation-api` from the s3 mock dependency in `s3-repository` and it broke all the tests. Since apparently `jakarta.annotation-api` is important - I decided it would be better to NOT exclude it from `tika-parsers` since it might come into play when parsing with Tika.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #693: SOLR-16048: Examine Tika dependencies that brought in javax classes
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on pull request #693:
URL: https://github.com/apache/solr/pull/693#issuecomment-1048913575
Yeah I know I added a lot of jakarta and jaxb dependencies with the s3-repository. Was definitely needed at the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #693: SOLR-16048: Examine Tika dependencies that brought in javax classes
Posted by GitBox <gi...@apache.org>.
risdenk merged pull request #693:
URL: https://github.com/apache/solr/pull/693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] uschindler commented on pull request #693: SOLR-16048: Examine Tika dependencies that brought in javax classes
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #693:
URL: https://github.com/apache/solr/pull/693#issuecomment-1048928108
> Agree. Would definitely be good to have this logic and whitelist in grade for early detection, but we can do that later.
Yes, I think we should add this as a gradle task. Having it only in smoke tester was the only possibility back at that time. Let's open a separate issue. This would also be useful for Lucene regarding accidentally importing servlet-api or others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #693: SOLR-16048: Examine Tika dependencies that brought in javax classes
Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #693:
URL: https://github.com/apache/solr/pull/693#issuecomment-1048922841
Agree. Would definitely be good to have this logic and whitelist in grade for early detection, but we can do that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org