You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Gus Heck (Jira)" <ji...@apache.org> on 2019/09/14 20:47:00 UTC

[jira] [Commented] (SOLR-13760) Date Math in "start" attribute of routed alias causes exception

    [ https://issues.apache.org/jira/browse/SOLR-13760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929819#comment-16929819 ] 

Gus Heck commented on SOLR-13760:
---------------------------------

The fix in the pull request parses the date math correctly. The interesting effect here is that a DRA configured with something like "start":"NOW/DAY" would never allow old documents for a new category no matter how long it's been running. I think it's possible to see this as a feature, but also possible to see it as a bit tricky or surprising. We might want to consider converting the NOW/DAY to a timestamp and updating the alias after the first document arrives for a DRA, thus creating a level "first date" across all categories. For a pure TRA this is not a problem because there is only one time series in play, and the first TRA collection is created, the start parameter is never used again.

As I type this I think I just realized that the fix in the PR still has a problem... I suspect that the NOW/DAY config will erroneously reject any document not in the present day because there's no check to see if a first collection exists already.... hmm

> Date Math in "start" attribute of routed alias causes exception
> ---------------------------------------------------------------
>
>                 Key: SOLR-13760
>                 URL: https://issues.apache.org/jira/browse/SOLR-13760
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrCloud
>    Affects Versions: 8.3
>            Reporter: Gus Heck
>            Assignee: Gus Heck
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The start parameter (for Time Routed Aliases and 2-Dimensional Routed Aliases using time components) is meant to accept date math as well as a timestamp. However it seems that none of the tests actually test this, and my changes for DRA forgot to account for it in one place, so an exception is thrown adding a document to an alias with such a configuration. Will add a test and a fix. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org