[GitHub] [cloudstack] davidjumani commented on a change in pull request #4239: Disabling managing firewall - cloudstack-setup-management

[GitBox <gi...@apache.org>]

davidjumani commented on a change in pull request #4239:
URL: https://github.com/apache/cloudstack/pull/4239#discussion_r468514496



##########
File path: python/lib/cloudutils/syscfg.py
##########
@@ -201,15 +201,15 @@ def check(self):
         if not hostname.isSuccess():
             raise CloudInternalException("Checking hostname ... [Failed]\nPlease edit /etc/hosts, add a Fully Qualified Domain Name as your hostname\n")
         return True
-        
+
 class sysConfigServerRedhat(sysConfigServer):
     def __init__(self, glbEnv):
         super(sysConfigServerRedhat, self).__init__(glbEnv)
         self.svo = serviceOpsRedhat()
-        self.services = [firewallConfigServer(self)]

Review comment:
       @rhtyd I was able to deploy a kvm env for basic testing, and everything seems to work. Will look into why it failed this time




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org