[GitHub] couchdb-couch pull request: Add couch_file:open_files/0

[tsutsu <gi...@git.apache.org>]

Github user tsutsu commented on the pull request:

    https://github.com/apache/couchdb-couch/pull/135#issuecomment-181614474
  
    I wouldn't expect a function called `couch_file:process_info(Pid)` to return a single property tuple, but rather a processed and filtered version of `erlang:process_info(Pid)`—a list of tuples.
    
    What you probably want is more like `erlang:process_info(Pid, Key)`—a key parameter to make it clear you're pulling out a particular tuple, e.g. `couch_file:process_info(Pid, fd)`. The function could just be defined for the `fd` case and nothing else.
    
    Other than that, looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---