You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2012/03/29 00:37:29 UTC

[jira] [Created] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
----------------------------------------------------------------------------------------

                 Key: FLUME-1074
                 URL: https://issues.apache.org/jira/browse/FLUME-1074
             Project: Flume
          Issue Type: Bug
          Components: Sinks+Sources
    Affects Versions: v1.1.0
            Reporter: Brock Noland


If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:

2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
        at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
        at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
        at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
        at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
        at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
        at java.lang.Thread.run(Thread.java:662)


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Mujumdar updated FLUME-1074:
-----------------------------------

    Attachment: FLUME-1074.patch
    
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Prasad Mujumdar
>         Attachments: FLUME-1074.patch
>
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242462#comment-13242462 ] 

jiraposter@reviews.apache.org commented on FLUME-1074:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4568/#review6578
-----------------------------------------------------------

Ship it!


+1

Thanks for the patch Prasad, please attach it to the Jira.

- Arvind


On 2012-03-30 05:33:54, Prasad Mujumdar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4568/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-30 05:33:54)
bq.  
bq.  
bq.  Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Add exception handlers to rollback open transactions in error cases.
bq.  
bq.  
bq.  This addresses bug FLUME-1074.
bq.      https://issues.apache.org/jira/browse/FLUME-1074
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 7e24e32 
bq.    flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e231cb8 
bq.  
bq.  Diff: https://reviews.apache.org/r/4568/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  regression test run
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Prasad
bq.  
bq.


                
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Prasad Mujumdar
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "Arvind Prabhakar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arvind Prabhakar updated FLUME-1074:
------------------------------------

       Resolution: Fixed
    Fix Version/s: v1.2.0
           Status: Resolved  (was: Patch Available)

Patch committed. Thanks Prasad!
                
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Prasad Mujumdar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1074.patch
>
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242157#comment-13242157 ] 

jiraposter@reviews.apache.org commented on FLUME-1074:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4568/#review6569
-----------------------------------------------------------


Prasad, good catch. These are the only two places with a Transaction.commit() and without a catch (Exception e) clause.

Looks good to me.

- Mike


On 2012-03-30 05:33:54, Prasad Mujumdar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4568/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-30 05:33:54)
bq.  
bq.  
bq.  Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Add exception handlers to rollback open transactions in error cases.
bq.  
bq.  
bq.  This addresses bug FLUME-1074.
bq.      https://issues.apache.org/jira/browse/FLUME-1074
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 7e24e32 
bq.    flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e231cb8 
bq.  
bq.  Diff: https://reviews.apache.org/r/4568/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  regression test run
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Prasad
bq.  
bq.


                
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Prasad Mujumdar
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242080#comment-13242080 ] 

jiraposter@reviews.apache.org commented on FLUME-1074:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4568/
-----------------------------------------------------------

Review request for Flume, Arvind Prabhakar and Mike Percy.


Summary
-------

Add exception handlers to rollback open transactions in error cases.


This addresses bug FLUME-1074.
    https://issues.apache.org/jira/browse/FLUME-1074


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 7e24e32 
  flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e231cb8 

Diff: https://reviews.apache.org/r/4568/diff


Testing
-------

regression test run


Thanks,

Prasad


                
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Prasad Mujumdar
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "Prasad Mujumdar (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Mujumdar reassigned FLUME-1074:
--------------------------------------

    Assignee: Prasad Mujumdar
    
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Prasad Mujumdar
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240804#comment-13240804 ] 

Brock Noland commented on FLUME-1074:
-------------------------------------

This is also true for HDFSEvent sink if a non-Exception throwable is thrown.
                
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243915#comment-13243915 ] 

Hudson commented on FLUME-1074:
-------------------------------

Integrated in flume-trunk #154 (See [https://builds.apache.org/job/flume-trunk/154/])
    FLUME-1074. Fix exception handling in AvroSink.

(Prasad Mujumdar via Arvind Prabhakar) (Revision 1308197)

     Result = SUCCESS
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1308197
Files : 
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java
* /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java

                
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Prasad Mujumdar
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1074.patch
>
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "Prasad Mujumdar (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242001#comment-13242001 ] 

Prasad Mujumdar commented on FLUME-1074:
----------------------------------------

Also for sources via ChannelProcessor. I will include that in the patch.

                
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Prasad Mujumdar
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (FLUME-1074) AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause

Posted by "Prasad Mujumdar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLUME-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Prasad Mujumdar updated FLUME-1074:
-----------------------------------

    Status: Patch Available  (was: Open)
    
> AvroSink if any non-caught exception is thrown, an exception is thrown in finally clause
> ----------------------------------------------------------------------------------------
>
>                 Key: FLUME-1074
>                 URL: https://issues.apache.org/jira/browse/FLUME-1074
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Prasad Mujumdar
>         Attachments: FLUME-1074.patch
>
>
> If AvroSink and perhaps others, if any non-caught exception is thrown before transaction.commit, the finally clause throws:
> 2012-03-28 17:31:24,560 ERROR org.apache.flume.SinkRunner: Unhandled exception, logging and sleeping for 5000ms
> java.lang.IllegalStateException: close() called when transaction is OPEN - you must either commit or rollback first
>         at com.google.common.base.Preconditions.checkState(Preconditions.java:172)
>         at org.apache.flume.channel.BasicTransactionSemantics.close(BasicTransactionSemantics.java:179)
>         at org.apache.flume.sink.AvroSink.process(AvroSink.java:269)
>         at org.apache.flume.sink.FailoverSinkProcessor.process(FailoverSinkProcessor.java:118)
>         at org.apache.flume.SinkRunner$PollingRunner.run(SinkRunner.java:148)
>         at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira