You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/18 11:06:45 UTC
[GitHub] [flink] twalthr commented on a change in pull request #14423: [FLINK-20673][table-planner-blink] ExecNode#getOutputType method should return LogicalType instead of RowType
twalthr commented on a change in pull request #14423:
URL: https://github.com/apache/flink/pull/14423#discussion_r545761272
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNode.java
##########
@@ -41,9 +41,11 @@
String getDesc();
/**
- * Returns the output {@link RowType} of this node.
+ * Returns the output {@link LogicalType} of this node,
+ * this type should be consistent with the type parameter {@link T}.
+ * Such as, T is RowData, the output type should be RowType.
*/
- RowType getOutputType();
+ LogicalType getOutputType();
Review comment:
You can link to JavaDoc of `RowData` for a mapping of logical types to internal data structures here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org