You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/02/25 14:02:00 UTC
[jira] [Commented] (TINKERPOP-2527) Add a GroovyTranslator
equivalent method to the Python client
[ https://issues.apache.org/jira/browse/TINKERPOP-2527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290930#comment-17290930 ]
ASF GitHub Bot commented on TINKERPOP-2527:
-------------------------------------------
spmallette commented on pull request #1399:
URL: https://github.com/apache/tinkerpop/pull/1399#issuecomment-785916191
I just pushed a commit on this branch to do two basic things:
1. Minor code formatting to PEP2 standards
2. Refactored tests to run with the standard build
Note that in doing so I noticed there was a failure on this test which made me change the assertion:
https://github.com/apache/tinkerpop/pull/1399/files#diff-f08dfe7ef61a419bb3393595484bacb700f5264213588c860625fb43e1099374R345-R346
I'm not sure exactly what happened there. Perhaps you could have a look to see if you're ok with that?
Lastly, I don't think we need to do it for this PR but I hope we can find a way to leverage our gherkin tests somehow to test translators here just as we do on the the JVM. This does look well tested however, so I'm good with how this is shaping up. We can save more advanced testing for later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Add a GroovyTranslator equivalent method to the Python client
> -------------------------------------------------------------
>
> Key: TINKERPOP-2527
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2527
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.5.0
> Reporter: Kelvin R. Lawrence
> Assignee: Kelvin R. Lawrence
> Priority: Major
>
> Currently there is no equivalent to GroovyTranslator for the Gremlin Python client. There is one in the JavaScript client however. Adding one for the Python client will further help in moving all the clients to a consistent level of functionality. I have this mostly coded up and will try to submit some code within the next few days.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)