(datafusion-ballista) branch main updated: address task policy comments (#1508)

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

milenkovicm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-ballista.git


The following commit(s) were added to refs/heads/main by this push:
     new d105e3100 address task policy comments (#1508)
d105e3100 is described below

commit d105e31006aa9795446e7f2f3cf32a4556132408
Author: Marko Milenković <mi...@users.noreply.github.com>
AuthorDate: Sun Mar 15 14:02:59 2026 +0000

    address task policy comments (#1508)
---
 ballista/core/src/config.rs      | 3 ---
 ballista/executor/src/config.rs  | 2 +-
 ballista/scheduler/src/config.rs | 2 +-
 3 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/ballista/core/src/config.rs b/ballista/core/src/config.rs
index 41daae4f6..2fde0a2b2 100644
--- a/ballista/core/src/config.rs
+++ b/ballista/core/src/config.rs
@@ -482,9 +482,6 @@ pub enum TaskSchedulingPolicy {
     /// Pull-based scheduling works in a similar way to Apache Spark
     PullStaged,
     /// push-based scheduling can result in lower latency.
-    // scheduler & executor cli configuration to be updated
-    // if we change default value, as they state which policy
-    // is default.
     #[default]
     PushStaged,
 }
diff --git a/ballista/executor/src/config.rs b/ballista/executor/src/config.rs
index c3700142e..d1d3b34ce 100644
--- a/ballista/executor/src/config.rs
+++ b/ballista/executor/src/config.rs
@@ -78,7 +78,7 @@ pub struct Config {
     )]
     pub concurrent_tasks: usize,
     /// Task scheduling policy: pull-staged (executor polls) or push-staged (scheduler pushes).
-    #[arg(short = 's', long, default_value_t = ballista_core::config::TaskSchedulingPolicy::default(), help = "The task scheduling policy for the scheduler, possible values: pull-staged, push-staged. Default: push-staged")]
+    #[arg(short = 's', long, default_value_t = ballista_core::config::TaskSchedulingPolicy::default(), help = "The task scheduling policy used by scheduler. Configuration must match with scheduler configured policy.")]
     pub task_scheduling_policy: ballista_core::config::TaskSchedulingPolicy,
     /// Interval in seconds between job data cleanup runs (0 = disabled).
     #[arg(
diff --git a/ballista/scheduler/src/config.rs b/ballista/scheduler/src/config.rs
index 41c218ec7..9ddede024 100644
--- a/ballista/scheduler/src/config.rs
+++ b/ballista/scheduler/src/config.rs
@@ -69,7 +69,7 @@ pub struct Config {
         short = 's',
         long,
         default_value_t = ballista_core::config::TaskSchedulingPolicy::default(),
-        help = "The scheduling policy for the scheduler, possible values: pull-staged, push-staged. Default: push-staged"
+        help = "The scheduling policy used by the scheduler. Executor configuration must match with scheduler configured policy."
     )]
     pub scheduler_policy: ballista_core::config::TaskSchedulingPolicy,
     /// Event loop buffer size for high throughput systems.


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org