You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Peeyush Bishnoi <bp...@yahoo.co.in> on 2015/05/06 14:47:51 UTC
Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1165
https://issues.apache.org/jira/browse/FALCON-1165
Repository: falcon-git
Description
-------
FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
Diffs
-----
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
Diff: https://reviews.apache.org/r/33892/diff/
Testing
-------
Yes
Thanks,
Peeyush Bishnoi
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On May 13, 2015, 10:40 a.m., Pallavi Rao wrote:
> > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, line 195
> > <https://reviews.apache.org/r/33892/diff/3/?file=958011#file958011line195>
> >
> > Nit : Logging the entire exception stack (as opposed to just the message) may be useful.
Entire exception stack trace added as suggested. thanks.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83587
-----------------------------------------------------------
On May 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 8:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83587
-----------------------------------------------------------
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment134599>
Nit : Logging the entire exception stack (as opposed to just the message) may be useful.
- Pallavi Rao
On May 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 8:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Ajay Yadava <aj...@gmail.com>.
> On May 14, 2015, 9:06 a.m., Ajay Yadava wrote:
> > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, line 195
> > <https://reviews.apache.org/r/33892/diff/3/?file=958011#file958011line195>
> >
> > I don't want to but I have to put another nit. toString() will not log the stacktrace. Since it is not logged at the lower level also, we will not know exactly why FS didn't get initialized.
>
> Peeyush Bishnoi wrote:
> Already fixed it in the patch.
Sorry, I didn't know that reviewboard wasn't updated with latest patch.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83736
-----------------------------------------------------------
On May 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 8:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On May 14, 2015, 9:06 a.m., Ajay Yadava wrote:
> > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, line 195
> > <https://reviews.apache.org/r/33892/diff/3/?file=958011#file958011line195>
> >
> > I don't want to but I have to put another nit. toString() will not log the stacktrace. Since it is not logged at the lower level also, we will not know exactly why FS didn't get initialized.
Already fixed it in the patch.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83736
-----------------------------------------------------------
On May 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 8:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83736
-----------------------------------------------------------
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment134786>
I don't want to but I have to put another nit. toString() will not log the stacktrace. Since it is not logged at the lower level also, we will not know exactly why FS didn't get initialized.
- Ajay Yadava
On May 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 8:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83588
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On May 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 8:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/
-----------------------------------------------------------
(Updated May 13, 2015, 8:58 a.m.)
Review request for Falcon.
Bugs: FALCON-1165
https://issues.apache.org/jira/browse/FALCON-1165
Repository: falcon-git
Description
-------
FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
Diffs (updated)
-----
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
Diff: https://reviews.apache.org/r/33892/diff/
Testing
-------
Yes
Thanks,
Peeyush Bishnoi
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On May 8, 2015, 4:42 p.m., Ajay Yadava wrote:
> >
Thanks for providing the comment. I have performed changes as required.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83007
-----------------------------------------------------------
On May 8, 2015, 8:50 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 8:50 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review83007
-----------------------------------------------------------
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133885>
From the way I see it you are passing another variable through both onAdd and onReload to introduce a new control branch(catch exception in case of add or throw it in case of reload). I am suggesting to let the addLibsTo always throw exception. If reload flow needs to continue then let it catch the exception. This way you don't need to alter onAdd or addLibsTo and only the onReload needs to change. Makes sense?
- Ajay Yadava
On May 8, 2015, 8:50 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 8, 2015, 8:50 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/
-----------------------------------------------------------
(Updated May 8, 2015, 8:50 a.m.)
Review request for Falcon.
Bugs: FALCON-1165
https://issues.apache.org/jira/browse/FALCON-1165
Repository: falcon-git
Description
-------
FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
Diffs
-----
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
Diff: https://reviews.apache.org/r/33892/diff/
Testing
-------
Yes
Thanks,
Peeyush Bishnoi
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/
-----------------------------------------------------------
(Updated May 8, 2015, 8:49 a.m.)
Review request for Falcon.
Changes
-------
Updated changes after incorporating review comments.
Bugs: FALCON-1165
https://issues.apache.org/jira/browse/FALCON-1165
Repository: falcon-git
Description
-------
FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
Diffs (updated)
-----
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
Diff: https://reviews.apache.org/r/33892/diff/
Testing
-------
Yes
File Attachments
----------------
FALCON-1165.v1.patch
https://reviews.apache.org/media/uploaded/files/2015/05/08/14f8df26-6c60-4ca9-96d2-6d1388e5dc7d__FALCON-1165.v1.patch
Thanks,
Peeyush Bishnoi
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/
-----------------------------------------------------------
(Updated May 8, 2015, 8:45 a.m.)
Review request for Falcon.
Changes
-------
Updated patch after incorporating review comments.
Bugs: FALCON-1165
https://issues.apache.org/jira/browse/FALCON-1165
Repository: falcon-git
Description
-------
FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
Diffs
-----
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
Diff: https://reviews.apache.org/r/33892/diff/
Testing
-------
Yes
File Attachments (updated)
----------------
FALCON-1165.v1.patch
https://reviews.apache.org/media/uploaded/files/2015/05/08/14f8df26-6c60-4ca9-96d2-6d1388e5dc7d__FALCON-1165.v1.patch
Thanks,
Peeyush Bishnoi
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On May 7, 2015, 4:48 a.m., Pallavi Rao wrote:
> >
Thanks Pallavi for your comments.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review82790
-----------------------------------------------------------
On May 6, 2015, 12:47 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 12:47 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On May 7, 2015, 4:48 a.m., Pallavi Rao wrote:
> > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, line 49
> > <https://reviews.apache.org/r/33892/diff/1/?file=951149#file951149line49>
> >
> > Using an instance variable to differentiate between add and reload will make it thread-unsafe.
> > Add and reload may not happen simultaneously in this case, but, lets keep it thread safe, anyway. You can achieve the same using method variables.
> >
> > You can add another private method:
> > private addEntity(Entity entity, isReload){..}
> >
> > public onAdd(Entity entity) {
> > addEntity(entity, false);
> > }
> >
> > public onReload(Entity entity) {
> > addEntity(entity, true);
> > }
Used method variables as suggested.
> On May 7, 2015, 4:48 a.m., Pallavi Rao wrote:
> > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, line 82
> > <https://reviews.apache.org/r/33892/diff/1/?file=951149#file951149line82>
> >
> > Don't think you need fsException variable at all. Using,
> > if (!reloadEntity) {
> > throw FalconException(...);
> > }
> > should do it. Isn't it?
I need to set variable fsException = true, if FS exception occurred while reloading cluster entity on Falcon server restart. If I don't set this, then Falcon server will try to add/update jar file for unavailable FS.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review82790
-----------------------------------------------------------
On May 6, 2015, 12:47 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 12:47 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review82790
-----------------------------------------------------------
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133608>
Using an instance variable to differentiate between add and reload will make it thread-unsafe.
Add and reload may not happen simultaneously in this case, but, lets keep it thread safe, anyway. You can achieve the same using method variables.
You can add another private method:
private addEntity(Entity entity, isReload){..}
public onAdd(Entity entity) {
addEntity(entity, false);
}
public onReload(Entity entity) {
addEntity(entity, true);
}
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133609>
Don't think you need fsException variable at all. Using,
if (!reloadEntity) {
throw FalconException(...);
}
should do it. Isn't it?
- Pallavi Rao
On May 6, 2015, 12:47 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 12:47 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On May 7, 2015, 10:51 a.m., Ajay Yadava wrote:
> >
Thanks Ajay for your comments.
> On May 7, 2015, 10:51 a.m., Ajay Yadava wrote:
> > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, line 198
> > <https://reviews.apache.org/r/33892/diff/1/?file=951149#file951149line198>
> >
> > We also need to log (warning) here that no new libraries were copied. If any new libraries were added then they will have to be copied manually.
Log message added.
> On May 7, 2015, 10:51 a.m., Ajay Yadava wrote:
> > oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java, line 199
> > <https://reviews.apache.org/r/33892/diff/1/?file=951149#file951149line199>
> >
> > How about just catching the exception here and remove all other changes? This way during reload we can silence the error in copying libs to HDFS without changing the code anywhere else.
In this issue, Falon fail to restart when FS exception occurred at the time of reloading cluster entities. So I am of the opinion that we should capture this FS exception only, at the time of FS initialization in addLibsTo method.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review82815
-----------------------------------------------------------
On May 6, 2015, 12:47 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 12:47 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 33892: FALCON-1165 : Falcon restart failed,
if defined service in cluster entity is unreachable
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33892/#review82815
-----------------------------------------------------------
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133645>
We also need to log (warning) here that no new libraries were copied. If any new libraries were added then they will have to be copied manually.
oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java
<https://reviews.apache.org/r/33892/#comment133644>
How about just catching the exception here and remove all other changes? This way during reload we can silence the error in copying libs to HDFS without changing the code anywhere else.
- Ajay Yadava
On May 6, 2015, 12:47 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33892/
> -----------------------------------------------------------
>
> (Updated May 6, 2015, 12:47 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1165
> https://issues.apache.org/jira/browse/FALCON-1165
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1165 : Falcon restart failed, if defined service in cluster entity is unreachable
>
>
> Diffs
> -----
>
> oozie/src/main/java/org/apache/falcon/service/SharedLibraryHostingService.java b3b7bf3
>
> Diff: https://reviews.apache.org/r/33892/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>