[GitHub] [helix] narendly commented on a diff in pull request #2036: Scheduled Workflow Znode - doesn't purge old entries

[GitBox <gi...@apache.org>]

narendly commented on code in PR #2036:
URL: https://github.com/apache/helix/pull/2036#discussion_r851329534


##########
helix-core/src/main/java/org/apache/helix/task/WorkflowContext.java:
##########
@@ -57,6 +57,9 @@ protected enum WorkflowContextProperties {
   // Otherwise, the context will not be written to ZK by the controller.
   private boolean isModified;
 
+  // Have fixed size history of Scheduled Workflow Tasks
+  private final static int SCHEDULED_WORKFLOW_HISTORY_SIZE = 100;

Review Comment:
   Thanks for making the fix. For the size here, should we use something smaller like 20?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org