You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@liminal.apache.org by jb...@apache.org on 2020/07/20 06:25:10 UTC

[incubator-liminal] 30/43: Fix missing tasks/dags bug

This is an automated email from the ASF dual-hosted git repository.

jbonofre pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-liminal.git

commit c21bfdf492e712315becd97b24843fdb3800f68c
Author: aviemzur <av...@gmail.com>
AuthorDate: Tue Apr 7 14:48:48 2020 +0300

    Fix missing tasks/dags bug
---
 rainbow/runners/airflow/dag/rainbow_dags.py | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/rainbow/runners/airflow/dag/rainbow_dags.py b/rainbow/runners/airflow/dag/rainbow_dags.py
index 17fd8d9..6b071fd 100644
--- a/rainbow/runners/airflow/dag/rainbow_dags.py
+++ b/rainbow/runners/airflow/dag/rainbow_dags.py
@@ -31,7 +31,7 @@ from rainbow.runners.airflow.tasks.defaults.job_start import JobStartTask
 
 def register_dags(configs_path):
     """
-    TODO: doc for register_dags
+    Registers pipelines in rainbow yml files found in given path (recursively) as airflow DAGs.
     """
 
     config_files = files_util.find_config_files(configs_path)
@@ -75,15 +75,16 @@ def register_dags(configs_path):
 
                     parent = task_instance.apply_task_to_dag()
 
-                    job_end_task = JobEndTask(dag, pipeline_name, parent, pipeline, 'all_done')
-                    job_end_task.apply_task_to_dag()
+                job_end_task = JobEndTask(dag, pipeline_name, parent, pipeline, 'all_done')
+                job_end_task.apply_task_to_dag()
 
-                    print(f'{pipeline_name}: {dag.tasks}')
+                print(f'{pipeline_name}: {dag.tasks}')
 
-                    globals()[pipeline_name] = dag
+                globals()[pipeline_name] = dag
 
-                    dags.append(dag)
-                    return dags
+                dags.append(dag)
+
+            return dags
 
 
 print(f'Loading task implementations..')